From: Sridhar Samudrala <sri@us.ibm.com>
To: Adrian Bunk <bunk@stusta.de>
Cc: lksctp-developers@lists.sourceforge.net,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [2.6 patch] net/sctp/: make 2 functions static
Date: Sun, 17 Dec 2006 16:40:28 -0800 [thread overview]
Message-ID: <4585E37C.7040105@us.ibm.com> (raw)
In-Reply-To: <20061216135703.GE3388@stusta.de>
Adrian Bunk wrote:
> This patch makes the following needlessly global functions static:
> - ipv6.c: sctp_inet6addr_event()
> - protocol.c: sctp_inetaddr_event()
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
>
Acked-by: Sridhar Samudrala <sri@us.ibm.com>
Thanks
Sridhar
> ---
>
> include/net/sctp/sctp.h | 2 --
> net/sctp/ipv6.c | 4 ++--
> net/sctp/protocol.c | 4 ++--
> 3 files changed, 4 insertions(+), 6 deletions(-)
>
> --- linux-2.6.20-rc1-mm1/net/sctp/ipv6.c.old 2006-12-16 01:05:15.000000000 +0100
> +++ linux-2.6.20-rc1-mm1/net/sctp/ipv6.c 2006-12-16 01:05:40.000000000 +0100
> @@ -79,8 +79,8 @@
> #include <asm/uaccess.h>
>
> /* Event handler for inet6 address addition/deletion events. */
> -int sctp_inet6addr_event(struct notifier_block *this, unsigned long ev,
> - void *ptr)
> +static int sctp_inet6addr_event(struct notifier_block *this, unsigned long ev,
> + void *ptr)
> {
> struct inet6_ifaddr *ifa = (struct inet6_ifaddr *)ptr;
> struct sctp_sockaddr_entry *addr;
> --- linux-2.6.20-rc1-mm1/include/net/sctp/sctp.h.old 2006-12-16 01:05:47.000000000 +0100
> +++ linux-2.6.20-rc1-mm1/include/net/sctp/sctp.h 2006-12-16 01:05:53.000000000 +0100
> @@ -128,8 +128,6 @@
> int flags);
> extern struct sctp_pf *sctp_get_pf_specific(sa_family_t family);
> extern int sctp_register_pf(struct sctp_pf *, sa_family_t);
> -int sctp_inetaddr_event(struct notifier_block *this, unsigned long ev,
> - void *ptr);
>
> /*
> * sctp/socket.c
> --- linux-2.6.20-rc1-mm1/net/sctp/protocol.c.old 2006-12-16 01:05:59.000000000 +0100
> +++ linux-2.6.20-rc1-mm1/net/sctp/protocol.c 2006-12-16 01:06:07.000000000 +0100
> @@ -601,8 +601,8 @@
> }
>
> /* Event handler for inet address addition/deletion events. */
> -int sctp_inetaddr_event(struct notifier_block *this, unsigned long ev,
> - void *ptr)
> +static int sctp_inetaddr_event(struct notifier_block *this, unsigned long ev,
> + void *ptr)
> {
> struct in_ifaddr *ifa = (struct in_ifaddr *)ptr;
> struct sctp_sockaddr_entry *addr;
>
> -
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2006-12-18 0:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-16 13:57 [2.6 patch] net/sctp/: make 2 functions static Adrian Bunk
2006-12-18 0:40 ` Sridhar Samudrala [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4585E37C.7040105@us.ibm.com \
--to=sri@us.ibm.com \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lksctp-developers@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.