From: Tejun Heo <htejun@gmail.com>
To: David Milburn <dmilburn@redhat.com>
Cc: jeff@garzik.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH] Fix ata_task_ioctl to return ATA registers on check condition
Date: Tue, 19 Dec 2006 16:20:40 +0900 [thread overview]
Message-ID: <458792C8.1010700@gmail.com> (raw)
In-Reply-To: <458174D7.1020307@redhat.com>
David Milburn wrote:
> The HDIO_DRIVE_TASK ioctl should output the taskfile register values,
> the smartctl utility checks the values of the lba registers specifically
> the values of lbam and lbah for failure status (0xf4 and 0x2c
> respectively). This patch will copy the ATA registers back to the
> user-space application on a check condition similiar to ata_cmd_ioctl().
>
> Please ACK or comment.
Acked-by: Tejun Heo <htejun@gmail.com>
Great, but you need to resend the patch with Signed-off-by: line.
--
tejun
prev parent reply other threads:[~2006-12-19 7:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-14 15:59 [PATCH] Fix ata_task_ioctl to return ATA registers on check condition David Milburn
2006-12-19 7:20 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=458792C8.1010700@gmail.com \
--to=htejun@gmail.com \
--cc=dmilburn@redhat.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.