From: Dmitry Osipenko <digetx@gmail.com>
To: Peter Geis <pgwipeout@gmail.com>
Cc: broonie@kernel.org, lgirdwood@gmail.com, robh+dt@kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH 2/2 v2] Add support for CPCAP regulators on Tegra devices.
Date: Tue, 24 Jul 2018 03:27:13 +0300 [thread overview]
Message-ID: <4588004.Gnq6nbUl2V@dimapc> (raw)
In-Reply-To: <20180723193848.32491-3-pgwipeout@gmail.com>
On Monday, 23 July 2018 22:38:48 MSK Peter Geis wrote:
> Added support for the CPCAP power management regulator functions on
> Tegra devices.
> Added sw2_sw4 value tables, which provide power to the Tegra core and
> aux devices.
> Added the Tegra init tables and device tree compatibility match.
>
> Signed-off-by: Peter Geis <pgwipeout@gmail.com>
> ---
> .../bindings/regulator/cpcap-regulator.txt | 1 +
> drivers/regulator/cpcap-regulator.c | 80 +++++++++++++++++++
> 2 files changed, 81 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/regulator/cpcap-regulator.txt
> b/Documentation/devicetree/bindings/regulator/cpcap-regulator.txt index
> 675f4437ce92..3e2d33ab1731 100644
> --- a/Documentation/devicetree/bindings/regulator/cpcap-regulator.txt
> +++ b/Documentation/devicetree/bindings/regulator/cpcap-regulator.txt
> @@ -4,6 +4,7 @@ Motorola CPCAP PMIC voltage regulators
> Requires node properties:
> - "compatible" value one of:
> "motorola,cpcap-regulator"
> + "motorola,tegra-cpcap-regulator"
> "motorola,mapphone-cpcap-regulator"
>
> Required regulator properties:
> diff --git a/drivers/regulator/cpcap-regulator.c
> b/drivers/regulator/cpcap-regulator.c index c0b1e04bd90f..cb3774be445d
> 100644
> --- a/drivers/regulator/cpcap-regulator.c
> +++ b/drivers/regulator/cpcap-regulator.c
> @@ -412,6 +412,82 @@ static struct cpcap_regulator omap4_regulators[] = {
> { /* sentinel */ },
> };
>
> +static struct cpcap_regulator tegra_regulators[] = {
> + CPCAP_REG(SW1, CPCAP_REG_S1C1, CPCAP_REG_ASSIGN2,
> + CPCAP_BIT_SW1_SEL, unknown_val_tbl,
> + 0, 0, 0, 0, 0, 0),
> + CPCAP_REG(SW2, CPCAP_REG_S2C1, CPCAP_REG_ASSIGN2,
> + CPCAP_BIT_SW2_SEL, sw2_sw4_val_tbl,
> + 0xf00, 0x7f, 0, 0x800, 0, 120),
> + CPCAP_REG(SW3, CPCAP_REG_S3C, CPCAP_REG_ASSIGN2,
> + CPCAP_BIT_SW3_SEL, unknown_val_tbl,
> + 0, 0, 0, 0, 0, 0),
> + CPCAP_REG(SW4, CPCAP_REG_S4C1, CPCAP_REG_ASSIGN2,
> + CPCAP_BIT_SW4_SEL, sw2_sw4_val_tbl,
> + 0xf00, 0x7f, 0, 0x900, 0, 100),
> + CPCAP_REG(SW5, CPCAP_REG_S5C, CPCAP_REG_ASSIGN2,
> + CPCAP_BIT_SW5_SEL, sw5_val_tbl,
> + 0x2a, 0, 0, 0x22, 0, 0),
> + CPCAP_REG(SW6, CPCAP_REG_S6C, CPCAP_REG_ASSIGN2,
> + CPCAP_BIT_SW6_SEL, unknown_val_tbl,
> + 0, 0, 0, 0, 0, 0),
> + CPCAP_REG(VCAM, CPCAP_REG_VCAMC, CPCAP_REG_ASSIGN2,
> + CPCAP_BIT_VCAM_SEL, vcam_val_tbl,
> + 0x87, 0x30, 4, 0x7, 0, 420),
> + CPCAP_REG(VCSI, CPCAP_REG_VCSIC, CPCAP_REG_ASSIGN3,
> + CPCAP_BIT_VCSI_SEL, vcsi_val_tbl,
> + 0x47, 0x10, 4, 0x7, 0, 350),
> + CPCAP_REG(VDAC, CPCAP_REG_VDACC, CPCAP_REG_ASSIGN3,
> + CPCAP_BIT_VDAC_SEL, vdac_val_tbl,
> + 0x87, 0x30, 4, 0x3, 0, 420),
> + CPCAP_REG(VDIG, CPCAP_REG_VDIGC, CPCAP_REG_ASSIGN2,
> + CPCAP_BIT_VDIG_SEL, vdig_val_tbl,
> + 0x87, 0x30, 4, 0x5, 0, 420),
> + CPCAP_REG(VFUSE, CPCAP_REG_VFUSEC, CPCAP_REG_ASSIGN3,
> + CPCAP_BIT_VFUSE_SEL, vfuse_val_tbl,
> + 0x80, 0xf, 0, 0x80, 0, 420),
> + CPCAP_REG(VHVIO, CPCAP_REG_VHVIOC, CPCAP_REG_ASSIGN3,
> + CPCAP_BIT_VHVIO_SEL, vhvio_val_tbl,
> + 0x17, 0, 0, 0x2, 0, 0),
> + CPCAP_REG(VSDIO, CPCAP_REG_VSDIOC, CPCAP_REG_ASSIGN2,
> + CPCAP_BIT_VSDIO_SEL, vsdio_val_tbl,
> + 0x87, 0x38, 3, 0x2, 0, 420),
> + CPCAP_REG(VPLL, CPCAP_REG_VPLLC, CPCAP_REG_ASSIGN3,
> + CPCAP_BIT_VPLL_SEL, vpll_val_tbl,
> + 0x43, 0x18, 3, 0x1, 0, 420),
> + CPCAP_REG(VRF1, CPCAP_REG_VRF1C, CPCAP_REG_ASSIGN3,
> + CPCAP_BIT_VRF1_SEL, vrf1_val_tbl,
> + 0xac, 0x2, 1, 0xc, 0, 10),
> + CPCAP_REG(VRF2, CPCAP_REG_VRF2C, CPCAP_REG_ASSIGN3,
> + CPCAP_BIT_VRF2_SEL, vrf2_val_tbl,
> + 0x23, 0x8, 3, 0x3, 0, 10),
> + CPCAP_REG(VRFREF, CPCAP_REG_VRFREFC, CPCAP_REG_ASSIGN3,
> + CPCAP_BIT_VRFREF_SEL, vrfref_val_tbl,
> + 0x23, 0x8, 3, 0x3, 0, 420),
> + CPCAP_REG(VWLAN1, CPCAP_REG_VWLAN1C, CPCAP_REG_ASSIGN3,
> + CPCAP_BIT_VWLAN1_SEL, vwlan1_val_tbl,
> + 0x47, 0x10, 4, 0x5, 0, 420),
> + CPCAP_REG(VWLAN2, CPCAP_REG_VWLAN2C, CPCAP_REG_ASSIGN3,
> + CPCAP_BIT_VWLAN2_SEL, vwlan2_val_tbl,
> + 0x20c, 0xc0, 6, 0x8, 0, 420),
> + CPCAP_REG(VSIM, CPCAP_REG_VSIMC, CPCAP_REG_ASSIGN3,
> + 0xffff, vsim_val_tbl,
> + 0x23, 0x8, 3, 0x3, 0, 420),
> + CPCAP_REG(VSIMCARD, CPCAP_REG_VSIMC, CPCAP_REG_ASSIGN3,
> + 0xffff, vsimcard_val_tbl,
> + 0x1e80, 0x8, 3, 0x1e00, 0, 420),
> + CPCAP_REG(VVIB, CPCAP_REG_VVIBC, CPCAP_REG_ASSIGN3,
> + CPCAP_BIT_VVIB_SEL, vvib_val_tbl,
> + 0x1, 0xc, 2, 0, 0x1, 500),
> + CPCAP_REG(VUSB, CPCAP_REG_VUSBC, CPCAP_REG_ASSIGN3,
> + CPCAP_BIT_VUSB_SEL, vusb_val_tbl,
> + 0x11c, 0x40, 6, 0xc, 0, 0),
> + CPCAP_REG(VAUDIO, CPCAP_REG_VAUDIOC, CPCAP_REG_ASSIGN4,
> + CPCAP_BIT_VAUDIO_SEL, vaudio_val_tbl,
> + 0x16, 0x1, 0, 0x4, 0, 0),
> + { /* sentinel */ },
> +};
> +
> static const struct of_device_id cpcap_regulator_id_table[] = {
> {
> .compatible = "motorola,cpcap-regulator",
> @@ -420,6 +496,10 @@ static const struct of_device_id
> cpcap_regulator_id_table[] = { .compatible =
> "motorola,mapphone-cpcap-regulator",
> .data = omap4_regulators,
> },
> + {
> + .compatible = "motorola,tegra-cpcap-regulator",
> + .data = tegra_regulators,
> + },
> {},
> };
> MODULE_DEVICE_TABLE(of, cpcap_regulator_id_table);
Are those cpcap_regulator values really common for all Tegra's? Probably
better to name the DT compatible like "motorola,xoom-cpcap-regulator" or
"motorola,mz602-cpcap-regulator".
The DT binding documentation should be updated with the new compatible value
in the Documentation/devicetree/bindings/regulator/cpcap-regulator.txt
next prev parent reply other threads:[~2018-07-24 0:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-23 19:38 [PATCH 0/2 v2] Add support for cpcap regulators on Tegra devices Peter Geis
2018-07-23 19:38 ` [PATCH 1/2 v2] Add sw2_sw4 voltage table to cpcap regulator Peter Geis
2018-07-23 19:38 ` [PATCH 2/2 v2] Add support for CPCAP regulators on Tegra devices Peter Geis
2018-07-24 0:27 ` Dmitry Osipenko [this message]
2018-07-24 1:57 ` Peter Geis
2018-07-24 11:14 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4588004.Gnq6nbUl2V@dimapc \
--to=digetx@gmail.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=pgwipeout@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.