From: Jeff Garzik <jeff@garzik.org>
To: conke.hu@gmail.com
Cc: Linux kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Add pci class code for SATA
Date: Tue, 19 Dec 2006 14:32:52 -0500 [thread overview]
Message-ID: <45883E64.20400@garzik.org> (raw)
In-Reply-To: <1166551886.2977.5.camel@localhost.localdomain>
Conke Hu wrote:
> Add pci class code 0x0106 for SATA to pci_ids.h
>
> signed-off-by: conke.hu@gmail.com
> --------------------
> --- linux-2.6.20-rc1/include/linux/pci_ids.h.orig 2006-12-20
> 01:58:30.000000000 +0800
> +++ linux-2.6.20-rc1/include/linux/pci_ids.h 2006-12-20
> 01:59:07.000000000 +0800
> @@ -15,6 +15,7 @@
> #define PCI_CLASS_STORAGE_FLOPPY 0x0102
> #define PCI_CLASS_STORAGE_IPI 0x0103
> #define PCI_CLASS_STORAGE_RAID 0x0104
> +#define PCI_CLASS_STORAGE_SATA 0x0106
> #define PCI_CLASS_STORAGE_SAS 0x0107
> #define PCI_CLASS_STORAGE_OTHER 0x0180
Two comments:
1) I think "_SATA" is an inaccurate description. It should be _AHCI AFAICS.
2) Typically we don't add constants unless they are used somewhere...
Jeff
next prev parent reply other threads:[~2006-12-19 19:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-17 19:15 [PATCH] Use ARRAY_SIZE() macro in i386 relocs.c file Robert P. J. Day
2006-12-19 18:11 ` [PATCH] Add pci class code for SATA Conke Hu
2006-12-19 19:32 ` Jeff Garzik [this message]
2006-12-20 3:13 ` Conke Hu
2006-12-20 3:41 ` Conke Hu
2006-12-20 3:52 ` Conke Hu
2006-12-20 3:58 ` Randy Dunlap
2007-01-08 2:29 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45883E64.20400@garzik.org \
--to=jeff@garzik.org \
--cc=conke.hu@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.