All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jim Fehlig <jfehlig@novell.com>
To: Xen-devel <xen-devel@lists.xensource.com>
Subject: [PATCH] [xend] Remove ':disk' suffix from device name in config
Date: Tue, 19 Dec 2006 15:49:25 -0700	[thread overview]
Message-ID: <45886C75.8090205@novell.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 335 bytes --]

Remove ':disk' suffix from dev entry in dev_info dictionary in 
XendConfig.py.

The suffix is added regardless of device type (vbd or tap) so it doesn't 
appear to add any semantics.  Additionally, clients would be forced to 
strip this suffix from the device name since something like 'hda:disk" 
is not a device name.

Regards,
Jim


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: xend-config-devname.patch --]
[-- Type: text/x-patch; name="xend-config-devname.patch", Size: 1508 bytes --]

# HG changeset patch
# User jfehlig@jfehlig2.provo.novell.com
# Date 1166568442 25200
# Node ID 72a013bc923efa47b3262849cd5611a16353abc5
# Parent  057f7c4dbed1c75a3fbe446d346cee04cff31497
Remove ':disk' suffix from dev entry in dev_info dictionary in XendConfig.py.

The suffix was added regardless of device type so it doesn't appear to add any semantics.  Additionally, clients would be forced to strip this suffix from the device name since something like 'hda:disk" is not a device name.

Signed-off-by: Jim Fehlig <jfehlig@novell.com>

diff -r 057f7c4dbed1 -r 72a013bc923e tools/python/xen/xend/XendConfig.py
--- a/tools/python/xen/xend/XendConfig.py	Tue Dec 19 12:00:11 2006 +0000
+++ b/tools/python/xen/xend/XendConfig.py	Tue Dec 19 15:47:22 2006 -0700
@@ -970,10 +970,10 @@ class XendConfig(dict):
             elif dev_type in ('vbd', 'tap'):
                 if dev_type == 'vbd':
                     dev_info['uname'] = cfg_xenapi.get('image', '')
-                    dev_info['dev'] = '%s:disk' % cfg_xenapi.get('device')
+                    dev_info['dev'] = cfg_xenapi.get('device')
                 elif dev_type == 'tap':
                     dev_info['uname'] = 'tap:qcow:%s' % cfg_xenapi.get('image')
-                    dev_info['dev'] = '%s:disk' % cfg_xenapi.get('device')
+                    dev_info['dev'] = cfg_xenapi.get('device')
                     
                 dev_info['driver'] = cfg_xenapi.get('driver')
                 dev_info['VDI'] = cfg_xenapi.get('VDI', '')

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

                 reply	other threads:[~2006-12-19 22:49 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45886C75.8090205@novell.com \
    --to=jfehlig@novell.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.