From: Keiichi KII <k-keiichi@bx.jp.nec.com>
To: mpm@selenic.com
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: [RFC][PATCH 2.6.19 take2 1/5] marking __init and remove drop initialization
Date: Thu, 21 Dec 2006 19:03:23 +0900 [thread overview]
Message-ID: <458A5BEB.8090400@bx.jp.nec.com> (raw)
In-Reply-To: <458A5AAE.30209@bx.jp.nec.com>
From: Keiichi KII <k-keiichi@bx.jp.nec.com>
This patch contains the following cleanups.
- add __init for initialization functions(option_setup() and
init_netconsole()).
- remove "drop" initialization in the netpoll structure.
Signed-off-by: Keiichi KII <k-keiichi@bx.jp.nec.com>
---
[changes]
1. stop to use anoymous enum.
2. remove unrelated changes(formatting changes).
--- linux-2.6.19/drivers/net/netconsole.c 2006-12-21 18:26:04.017895000 +0900
+++ enhanced-netconsole/drivers/net/netconsole.c.cleanup 2006-12-21 18:38:34.080771000 +0900
@@ -60,7 +60,6 @@ static struct netpoll np = {
.local_port = 6665,
.remote_port = 6666,
.remote_mac = {0xff, 0xff, 0xff, 0xff, 0xff, 0xff},
- .drop = netpoll_queue,
};
static int configured = 0;
@@ -92,7 +91,7 @@ static struct console netconsole = {
.write = write_msg
};
-static int option_setup(char *opt)
+static int __init option_setup(char *opt)
{
configured = !netpoll_parse_options(&np, opt);
return 1;
@@ -100,7 +99,7 @@ static int option_setup(char *opt)
__setup("netconsole=", option_setup);
-static int init_netconsole(void)
+static int __init init_netconsole(void)
{
if(strlen(config))
option_setup(config);
--
Keiichi KII
NEC Corporation OSS Promotion Center
E-mail: k-keiichi@bx.jp.nec.com
next prev parent reply other threads:[~2006-12-21 10:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-21 9:58 [RFC][PATCH 2.6.19 take2 0/5] proposal for dynamic configurable netconsole Keiichi KII
2006-12-21 10:03 ` Keiichi KII [this message]
2006-12-22 5:06 ` [RFC][PATCH 2.6.19 take2 1/5] marking __init and remove drop initialization Matt Mackall
2006-12-21 10:09 ` [RFC][PATCH 2.6.19 take2 3/5] add interface for netconsole using sysfs Keiichi KII
2006-12-21 10:11 ` [RFC][PATCH 2.6.19 take2 4/5] switch function of netpoll Keiichi KII
2006-12-21 10:13 ` [RFC][PATCH 2.6.19 take2 5/5] add "add" element in /sys/class/misc/netconsole Keiichi KII
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=458A5BEB.8090400@bx.jp.nec.com \
--to=k-keiichi@bx.jp.nec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.