From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH] two missing bits (was Re: Add -Wcast-qual flag) Date: Fri, 22 Dec 2006 09:51:41 +0000 Message-ID: <458BB8BD.76E4.0078.0@novell.com> References: <458BB3E5.76E4.0078.0@novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Christoph Egger , Keir Fraser Cc: xen-devel@lists.xensource.com, Keir Fraser List-Id: xen-devel@lists.xenproject.org If this was with -Wconst-qual, yes. But didn't we agree that at least for now we'll not add that warning (and hence we also don't absolutely have to change code only affected by it)? Jan >>> Keir Fraser 22.12.06 10:40 >>> Maybe we need a CONST_ADDR macro, as I suspect the problem is the cast hidden inside the ADDR macro is dropping the const qualifier. -- Keir On 22/12/06 9:31 am, "Jan Beulich" wrote: > I object to the change to variable_test_bit() - why is that needed? I had > specifically > submitted a patch to get the const qualifier added there. Jan > >>>> "Christoph Egger" 22.12.06 10:05 >>> > > Hi! > > I catched two pieces with debug and crash_debug enabled. > One of them fixes a build error even without the -Wcast-qual flag. > > Patch attached. > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel