All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabrice Bellard <fabrice@bellard.org>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] qemu elf_ops.h loader.c hw/mips_r4k.c target-ar...
Date: Sat, 23 Dec 2006 15:57:25 +0100	[thread overview]
Message-ID: <458D43D5.6060001@bellard.org> (raw)
In-Reply-To: <E1Gy7hw-0002hx-I5@savannah.gnu.org>

Your change in elf_ops.h regarding the labels fail1 and fail2 is not 
necessary: qemu_free(NULL) is perfectly valid and there are many pieces 
of code relying on it. Please revert.

Regards,

Fabrice.

Thiemo Seufer wrote:
> CVSROOT:	/sources/qemu
> Module name:	qemu
> Changes by:	Thiemo Seufer <ths>	06/12/23 14:18:40
> 
> Modified files:
> 	.              : elf_ops.h loader.c 
> 	hw             : mips_r4k.c 
> 	target-arm     : cpu.h 
> 	target-i386    : cpu.h 
> 	target-m68k    : cpu.h 
> 	target-mips    : cpu.h 
> 	target-ppc     : cpu.h 
> 	target-sh4     : cpu.h 
> 	target-sparc   : cpu.h 
> 
> Log message:
> 	Check ELF binaries for machine type and endianness.
> 
> CVSWeb URLs:
> http://cvs.savannah.gnu.org/viewcvs/qemu/elf_ops.h?cvsroot=qemu&r1=1.3&r2=1.4
> http://cvs.savannah.gnu.org/viewcvs/qemu/loader.c?cvsroot=qemu&r1=1.3&r2=1.4
> http://cvs.savannah.gnu.org/viewcvs/qemu/hw/mips_r4k.c?cvsroot=qemu&r1=1.27&r2=1.28
> http://cvs.savannah.gnu.org/viewcvs/qemu/target-arm/cpu.h?cvsroot=qemu&r1=1.17&r2=1.18
> http://cvs.savannah.gnu.org/viewcvs/qemu/target-i386/cpu.h?cvsroot=qemu&r1=1.38&r2=1.39
> http://cvs.savannah.gnu.org/viewcvs/qemu/target-m68k/cpu.h?cvsroot=qemu&r1=1.1&r2=1.2
> http://cvs.savannah.gnu.org/viewcvs/qemu/target-mips/cpu.h?cvsroot=qemu&r1=1.15&r2=1.16
> http://cvs.savannah.gnu.org/viewcvs/qemu/target-ppc/cpu.h?cvsroot=qemu&r1=1.23&r2=1.24
> http://cvs.savannah.gnu.org/viewcvs/qemu/target-sh4/cpu.h?cvsroot=qemu&r1=1.3&r2=1.4
> http://cvs.savannah.gnu.org/viewcvs/qemu/target-sparc/cpu.h?cvsroot=qemu&r1=1.25&r2=1.26
> 
> 
> _______________________________________________
> Qemu-devel mailing list
> Qemu-devel@nongnu.org
> http://lists.nongnu.org/mailman/listinfo/qemu-devel
> 
> 

  reply	other threads:[~2006-12-23 14:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-23 14:18 [Qemu-devel] qemu elf_ops.h loader.c hw/mips_r4k.c target-ar Thiemo Seufer
2006-12-23 14:57 ` Fabrice Bellard [this message]
2006-12-23 15:22   ` Thiemo Seufer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=458D43D5.6060001@bellard.org \
    --to=fabrice@bellard.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.