All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: netdev@vger.kernel.org, akpm@osdl.org,
	Ayaz Abdulla <aabdulla@nvidia.com>,
	Gary Zambrano <zambrano@broadcom.com>,
	Stephen Hemminger <shemminger@osdl.org>
Subject: Re: [PATCH] netpoll: drivers must not enable IRQ unconditionally in their NAPI handler
Date: Tue, 26 Dec 2006 16:24:21 -0500	[thread overview]
Message-ID: <45919305.90603@garzik.org> (raw)
In-Reply-To: <20061217220315.GA26485@electric-eye.fr.zoreil.com>

Francois Romieu wrote:
> net/core/netpoll.c::netpoll_send_skb() calls the poll handler when
> it is available. As netconsole can be used from almost any context,
> IRQ must not be enabled blindly in the NAPI handler of a driver which
> supports netpoll.
> 
> b57bd06655a028aba7b92e1c19c2093e7fcfb341 fixed the issue for the
> 8139too.c driver.
> 
> Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>

applied



      reply	other threads:[~2006-12-26 21:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-17 22:03 [PATCH] netpoll: drivers must not enable IRQ unconditionally in their NAPI handler Francois Romieu
2006-12-26 21:24 ` Jeff Garzik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45919305.90603@garzik.org \
    --to=jeff@garzik.org \
    --cc=aabdulla@nvidia.com \
    --cc=akpm@osdl.org \
    --cc=netdev@vger.kernel.org \
    --cc=romieu@fr.zoreil.com \
    --cc=shemminger@osdl.org \
    --cc=zambrano@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.