From: Jeff Garzik <jgarzik@pobox.com>
To: Tejun Heo <htejun@gmail.com>
Cc: linux-ide@vger.kernel.org, Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH] via82cxxx: fix cable detection
Date: Wed, 27 Dec 2006 12:20:11 -0500 [thread overview]
Message-ID: <4592AB4B.1010609@pobox.com> (raw)
In-Reply-To: <20061227124659.GB10987@htj.dyndns.org>
Tejun Heo wrote:
> Cable detection got broken probably while converting the driver to
> support multiple controllers. Cable detection is done by examining
> how BIOS configured the attached devices. The current code is broken
> in that it examines the status *after* modifying Clk66 configuration
> ending up detecting 40c cables as 80c. This patch fixes it.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> ---
>
> This certainly is a regression and there are users affected by this.
> I've verified this on both primary and secondary channel of vt6421.
> Who takes IDE patches these days? Jeff, can you push this through
> libata-dev#upstream-fixes?
I would guess Alan or Andrew or (who just replied) Bart.
You can count on me to /not/ apply drivers/ide patches. It's easier
that way, if I stay out of that game.
Jeff
prev parent reply other threads:[~2006-12-27 17:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-27 12:46 [PATCH] via82cxxx: fix cable detection Tejun Heo
2006-12-27 13:45 ` Bartlomiej Zolnierkiewicz
2006-12-27 17:20 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4592AB4B.1010609@pobox.com \
--to=jgarzik@pobox.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.