All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <htejun@gmail.com>
To: Art Haas <ahaas@airmail.net>
Cc: linux-ide@vger.kernel.org
Subject: Re: CDROM drive not found when booting using new libata code
Date: Thu, 28 Dec 2006 12:51:06 +0900	[thread overview]
Message-ID: <45933F2A.5070304@gmail.com> (raw)
In-Reply-To: <45927532.3060404@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 487 bytes --]

Tejun Heo wrote:
> Art Haas wrote:
>> Sorry to report that patch did not work. I applied the patch against
>> Linus's tree this morning, built and installed that kernel, and
>> the CD-ROM was not found. I also tried the patch with an update
>> from Linus's tree from this evening, and again the same result.
> 
> Hello, Art.
> 
> Can you please test the attached patch?  The patch is against 2.6.19.
> Please give me my late christmas gift.

Please test this patch too.  TIA.

-- 
tejun

[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 588 bytes --]

diff --git a/include/linux/libata.h b/include/linux/libata.h
index abd2deb..7a4cf9e 100644
--- a/include/linux/libata.h
+++ b/include/linux/libata.h
@@ -1166,6 +1166,14 @@ static inline u8 ata_irq_on(struct ata_port *ap)
 	ap->ctl &= ~ATA_NIEN;
 	ap->last_ctl = ap->ctl;
 
+	ap->ops->dev_select(ap, 1);
+	if (ap->flags & ATA_FLAG_MMIO)
+		writeb(ap->ctl, (void __iomem *) ioaddr->ctl_addr);
+	else
+		outb(ap->ctl, ioaddr->ctl_addr);
+	tmp = ata_wait_idle(ap);
+
+	ap->ops->dev_select(ap, 0);
 	if (ap->flags & ATA_FLAG_MMIO)
 		writeb(ap->ctl, (void __iomem *) ioaddr->ctl_addr);
 	else

  reply	other threads:[~2006-12-28  3:51 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-24 22:10 CDROM drive not found when booting using new libata code Art Haas
2006-11-21  9:26 ` Tejun Heo
2006-12-06 18:16   ` Art Haas
2006-12-07  4:28     ` Tejun Heo
2006-12-07 10:55       ` Alan
2006-12-07 12:37         ` Tejun Heo
2006-12-08  1:06           ` Art Haas
2006-12-27 13:29             ` Tejun Heo
2006-12-28  3:51               ` Tejun Heo [this message]
2007-01-02 21:07                 ` Art Haas
2007-01-03  3:31                   ` Tejun Heo
2007-01-03 18:08                     ` Art Haas
2007-01-03 23:19                       ` Dâniel Fraga
  -- strict thread matches above, loose matches on Subject: below --
2007-03-14 19:33 YUP
2007-03-14 19:59 YUP

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45933F2A.5070304@gmail.com \
    --to=htejun@gmail.com \
    --cc=ahaas@airmail.net \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.