From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: Yoshimi Ichiyanagi
<ichiyanagi.yoshimi-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
moriai.satoshi-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org,
kihara.seiji-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org
Subject: Re: [PATCH] kvm: initialize kvm_arch_ops in kvm_init()
Date: Thu, 28 Dec 2006 15:44:00 +0200 [thread overview]
Message-ID: <4593CA20.9060908@qumranet.com> (raw)
In-Reply-To: <8FC72A6E4061FDichiyanagi.yoshimi-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org>
Yoshimi Ichiyanagi wrote:
>> This bit is unnecessary, no? I think kvm_init() will only be called
>> after the module is loaded, at which point kvm_arch_ops is initialized
>>
> >from the .bss section.
>
>
> Logically it's not required, however it's better to initialize
> explicitly in general.
>
>
Personally I agree, but Linux coding style does not.
> By the way, the previous patch didn't fix the problem completely.
> You can't load the supported arch's module
> if you load the unsupported arch's module beforehand.
>
> The following patch will fix this problem.
> Please take a look.
>
Applied, thanks.
--
error compiling committee.c: too many arguments to function
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
prev parent reply other threads:[~2006-12-28 13:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-26 6:59 [PATCH] kvm: initialize kvm_arch_ops in kvm_init() Yoshimi Ichiyanagi
[not found] ` <86C728BB73C10Bichiyanagi.yoshimi-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org>
2006-12-26 8:44 ` Avi Kivity
[not found] ` <4590E0DE.7030808-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2006-12-26 9:24 ` Yoshimi Ichiyanagi
2006-12-28 10:52 ` Yoshimi Ichiyanagi
[not found] ` <8FC72A6E4061FDichiyanagi.yoshimi-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org>
2006-12-28 13:44 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4593CA20.9060908@qumranet.com \
--to=avi-atkuwr5tajbwk0htik3j/w@public.gmane.org \
--cc=ichiyanagi.yoshimi-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org \
--cc=kihara.seiji-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org \
--cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=moriai.satoshi-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.