Re: [PATCH] correct return value handling in libsemanage

[Joshua Brindle <jbrindle@tresys.com>]

Karl MacMillan wrote:
> The function semanage_direct_commit in libsemanage:direct_api.c does 
> not correctly propagate error codes. This patch fixes that.
>
> Signed-off-by: Karl MacMillan <kmacmillan@mentalrootkit.com>
>
Acked-By: Joshua Brindle <jbrindle@tresys.com>
>
> diff -r 1ecfd5befe3f src/direct_api.c
> --- a/src/direct_api.c    Thu Dec 21 17:09:45 2006 -0500
> +++ b/src/direct_api.c    Thu Dec 21 17:47:06 2006 -0500
> @@ -603,7 +603,8 @@ static int semanage_direct_commit(semana
>
>          /* Create new policy object, then attach to policy databases
>           * that work with a policydb */
> -        if (semanage_expand_sandbox(sh, base, &out) < 0)
> +        retval = semanage_expand_sandbox(sh, base, &out);
> +        if (retval < 0)
>              goto cleanup;
>
>          dbase_policydb_attach((dbase_policydb_t *) pusers_base->dbase,
> @@ -615,13 +616,16 @@ static int semanage_direct_commit(semana
>
>          /* ============= Apply changes, and verify  =============== */
>
> -        if (semanage_base_merge_components(sh) < 0)
> -            goto cleanup;
> -
> -        if (semanage_write_policydb(sh, out) < 0)
> -            goto cleanup;
> -
> -        if (semanage_verify_kernel(sh) != 0)
> +        retval = semanage_base_merge_components(sh);
> +        if (retval < 0)
> +            goto cleanup;
> +
> +        retval = semanage_write_policydb(sh, out);
> +        if (retval < 0)
> +            goto cleanup;
> +
> +        retval = semanage_verify_kernel(sh);
> +        if (retval < 0)
>              goto cleanup;
>      }
>
> @@ -635,26 +639,30 @@ static int semanage_direct_commit(semana
>       * merged into the main file_contexts. We won't check the
>       * large file_contexts - checked at compile time */
>      if (sh->do_rebuild || modified || fcontexts_modified) {
> -        if (semanage_fcontext_validate_local(sh, out) < 0)
> +        retval = semanage_fcontext_validate_local(sh, out);
> +        if (retval < 0)
>              goto cleanup;
>      }
>
>      /* Validate local seusers against policy */
>      if (sh->do_rebuild || modified || seusers_modified) {
> -        if (semanage_seuser_validate_local(sh, out) < 0)
> +        retval = semanage_seuser_validate_local(sh, out);
> +        if (retval < 0)
>              goto cleanup;
>      }
>
>      /* Validate local ports for overlap */
>      if (sh->do_rebuild || ports_modified) {
> -        if (semanage_port_validate_local(sh) < 0)
> +        retval = semanage_port_validate_local(sh);
> +        if (retval < 0)
>              goto cleanup;
>      }
>
>      /* ================== Write non-policydb components ========= */
>
>      /* Commit changes to components */
> -    if (semanage_commit_components(sh) < 0)
> +    retval = semanage_commit_components(sh);
> +    if (retval < 0)
>          goto cleanup;
>
>      retval = semanage_install_sandbox(sh);
>
>
> -- 
> This message was distributed to subscribers of the selinux mailing list.
> If you no longer wish to subscribe, send mail to 
> majordomo@tycho.nsa.gov with
> the words "unsubscribe selinux" without quotes as the message.
>



--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.