All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pierre Ossman <drzeus-list@drzeus.cx>
To: Philip Langdale <philipl@overt.org>
Cc: linux-kernel@vger.kernel.org, John Gilmore <gnu@toad.com>
Subject: Re: [PATCH 2.6.19] mmc: Add support for SDHC cards
Date: Wed, 03 Jan 2007 22:05:59 +0100	[thread overview]
Message-ID: <459C1AB7.9070901@drzeus.cx> (raw)
In-Reply-To: <459926B5.60505@overt.org>

Philip Langdale wrote:
> Heh. I forget that you don't want to manually alter the email. Will do.
>
>   

I'm rather reluctant to change anything once someone has put a
signed-off-by line to it. Different people have different limits as to
what they regard a trivial modification.

> Done. I thought we needed it before both SD_APP_SEND_OP_COND calls but
> it's only needed before the second one so I've moved it inline into
> mmc_setup.
>
>   

The spec says we need it at both (even though it might not be so in
practice). We should follow the spec first and foremost.

Rgds

-- 
     -- Pierre Ossman

  Linux kernel, MMC maintainer        http://www.kernel.org
  PulseAudio, core developer          http://pulseaudio.org
  rdesktop, core developer          http://www.rdesktop.org


      reply	other threads:[~2007-01-03 21:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-22 18:24 [PATCH 2.6.19] mmc: Add support for SDHC cards Philip Langdale
2006-12-22 18:50 ` Philip Langdale
2006-12-28 13:36   ` Pavel Machek
2007-01-01 17:49     ` Pierre Ossman
2006-12-31 11:46 ` Pierre Ossman
2007-01-01 15:20   ` Philip Langdale
2007-01-03 21:05     ` Pierre Ossman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=459C1AB7.9070901@drzeus.cx \
    --to=drzeus-list@drzeus.cx \
    --cc=gnu@toad.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=philipl@overt.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.