From: Mark Lord <liml@rtr.ca>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: dougg@torque.net, Linux IDE <linux-ide@vger.kernel.org>,
Tejun Heo <htejun@gmail.com>, Jeff Garzik <jeff@garzik.org>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] SCSI, libata: add support for ATA_16 commands to libata ATAPI devices
Date: Wed, 03 Jan 2007 18:57:43 -0500 [thread overview]
Message-ID: <459C42F7.2000000@rtr.ca> (raw)
In-Reply-To: <1167860496.2789.70.camel@mulgrave.il.steeleye.com>
James Bottomley wrote:
>
> As I read the code Mark sent me, current libata will only accept ATA_16
> for ATAPI devices (whether type 5 or not) ... pehaps this needs to be
> altered?
It could be.
Both ATA_12 and ATA_16 are just ways of getting a taskfile sent
down to the LLD, and ATA_12 is merely a restricted subset of ATA_16
so it is not really necessary here.
I think that given the opcode conflict with "BLANK", it may be best for
the moment to just not bother with ATA_12 for libata ATAPI. We don't really
have a need for ATA_12 anyway, as ATA_16 is more flexible.
And any application code that uses these isn't going to want to have
to vary its commands between ATA_12 and ATA_16 depending upon the target.
I think they'll all just go straight for ATA_16 for uniformity and
to minimize testing drudgery.
hdparm will certainly use only ATA_16 once it becomes available in SCSI/libata.
Cheers
next prev parent reply other threads:[~2007-01-03 23:57 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-03 0:35 [PATCH] SCSI, libata: add support for ATA_16 commands to libata ATAPI devices Mark Lord
2007-01-03 1:40 ` James Bottomley
2007-01-03 5:42 ` Mark Lord
2007-01-03 15:31 ` James Bottomley
2007-01-03 15:45 ` Jeff Garzik
2007-01-03 15:57 ` James Bottomley
2007-01-03 17:58 ` Mark Lord
2007-01-03 19:39 ` Douglas Gilbert
2007-01-03 21:41 ` James Bottomley
2007-01-03 23:57 ` Mark Lord [this message]
2007-01-04 15:09 ` Jens Axboe
2007-01-04 15:29 ` Mark Lord
2007-01-04 15:51 ` Jens Axboe
2007-01-08 5:00 ` Luben Tuikov
[not found] ` <200701311346.26644.liml@rtr.ca>
2007-02-01 0:33 ` [PATCH] RESEND: " Tejun Heo
2007-02-01 0:42 ` Mark Lord
2007-02-01 0:48 ` James Bottomley
2007-02-01 0:53 ` Mark Lord
2007-02-01 0:48 ` Tejun Heo
2007-02-01 1:01 ` Mark Lord
2007-02-01 8:30 ` Jeff Garzik
2007-02-01 8:28 ` Jeff Garzik
2007-02-01 8:43 ` Tejun Heo
2007-02-01 9:54 ` Jeff Garzik
2007-02-01 15:09 ` James Bottomley
2007-02-01 15:15 ` Jeff Garzik
2007-02-01 20:21 ` Douglas Gilbert
2007-02-01 20:30 ` Jeff Garzik
2007-02-02 9:11 ` Christoph Hellwig
2007-02-01 8:26 ` Jeff Garzik
2007-02-01 8:35 ` Tejun Heo
2007-02-01 9:52 ` Jeff Garzik
2007-02-01 0:44 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=459C42F7.2000000@rtr.ca \
--to=liml@rtr.ca \
--cc=James.Bottomley@SteelEye.com \
--cc=dougg@torque.net \
--cc=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.