All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pierre Peiffer <pierre.peiffer@bull.net>
To: Ingo Molnar <mingo@elte.hu>
Cc: LKML <linux-kernel@vger.kernel.org>,
	"Dinakar Guniguntala" <dino@in.ibm.com>,
	"Jean-Pierre Dion" <jean-pierre.dion@bull.net>,
	"Sébastien Dugué" <sebastien.dugue@bull.net>,
	"Ulrich Drepper" <drepper@redhat.com>,
	"Darren Hart" <dvhltc@us.ibm.com>
Subject: Re: [PATCH 2.6.19.1-rt15][RFC] - futex_requeue_pi implementation (requeue from futex1 to PI-futex2)
Date: Thu, 04 Jan 2007 08:59:34 +0100	[thread overview]
Message-ID: <459CB3E6.9080906@bull.net> (raw)
In-Reply-To: <20070103155609.GB11066@elte.hu>

Ingo Molnar a écrit :
> * Pierre Peiffer <pierre.peiffer@bull.net> wrote:
> 
>> Ingo Molnar a écrit :
>>> looks good to me in principle. The size of the patch is scary - is there 
>>> really no simpler way? 
>> Humf, in fact, for the 64-bit part, I've followed the rule of the 
>> existing 64-bit code in futex.c, which consists of duplicating all the 
>> functions which can not be kept common, and add a suffix 64 to all 
>> duplicated functions. Perhaps I missed something ?
> 
> i dont think you missed anything - but some consolidation here would be 
> nice. Only if possible of course :-)

Ok ;-)
So, you are not only speaking about "my" part of duplicated code, right ?
But, just for information, what is the sys_futex64 for, exactly ? Is there a 
plan to have in the future a 64-bit PID ? Because for now, 32-bits futex is 
enough, so... ?
Otherwise, I don't have a "clean" way to avoid this duplication.... :-/

-- 
Pierre Peiffer

  reply	other threads:[~2007-01-04  8:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-03 12:32 [PATCH 2.6.19.1-rt15][RFC] - futex_requeue_pi implementation (requeue from futex1 to PI-futex2) Pierre Peiffer
2007-01-03 12:35 ` Ingo Molnar
2007-01-03 14:35   ` Pierre Peiffer
2007-01-03 15:56     ` Ingo Molnar
2007-01-04  7:59       ` Pierre Peiffer [this message]
2007-01-04  8:08         ` Ulrich Drepper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=459CB3E6.9080906@bull.net \
    --to=pierre.peiffer@bull.net \
    --cc=dino@in.ibm.com \
    --cc=drepper@redhat.com \
    --cc=dvhltc@us.ibm.com \
    --cc=jean-pierre.dion@bull.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=sebastien.dugue@bull.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.