From: Robert Hancock <hancockr@shaw.ca>
To: Brice Goglin <brice@myri.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Cc: Greg KH <gregkh@suse.de>, Michael Ellerman <michael@ellerman.id.au>
Subject: Re: [PATCH] increment pos before looking for the next cap in __pci_find_next_ht_cap
Date: Fri, 05 Jan 2007 17:58:19 -0600 [thread overview]
Message-ID: <459EE61B.2070408@shaw.ca> (raw)
In-Reply-To: <fa.HKQ/+MClSV6hJeIdmFjKhgngCZQ@ifi.uio.no>
Brice Goglin wrote:
> Hi,
>
> While testing 2.6.20-rc3 on a machine with some CK804 chipsets, we
> noticed that quirk_nvidia_ck804_msi_ht_cap() was not detecting HT
> MSI capabilities anymore. It is actually caused by the MSI mapping
> on the root chipset being the 2nd HT capability in the chain.
> pci_find_ht_capability() does not seem to find anything but the
> first HT cap correctly, because it forgets to increment the position
> before looking for the next cap. The following patch seems to fix it.
>
> At least, this prooves that having a ttl is good idea since the
> machine would have been stucked in an infinite loop if we didn't
> have a ttl :)
>
> The patch should go in 2.6.20 since this quirk was working fine in 2.6.19.
Yes, I saw this on my A8N-SLI Deluxe board as well. This is a regression
since MSI is being disabled on the PCI Express slots when it wasn't before..
--
Robert Hancock Saskatoon, SK, Canada
To email, remove "nospam" from hancockr@nospamshaw.ca
Home Page: http://www.roberthancock.com/
next parent reply other threads:[~2007-01-05 23:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <fa.HKQ/+MClSV6hJeIdmFjKhgngCZQ@ifi.uio.no>
2007-01-05 23:58 ` Robert Hancock [this message]
2007-01-07 23:37 ` [PATCH] increment pos before looking for the next cap in __pci_find_next_ht_cap Michael Ellerman
2007-01-05 22:52 Brice Goglin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=459EE61B.2070408@shaw.ca \
--to=hancockr@shaw.ca \
--cc=brice@myri.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.