From: Jeff Garzik <jeff@garzik.org>
To: Alan <alan@lxorguk.ukuu.org.uk>
Cc: Uwe Koziolek <uwe.koziolek@gmx.net>,
"linux.ide" <linux-ide@vger.kernel.org>,
Sven Ladegast <sven@linux4geeks.de>
Subject: Re: [PATCH 2.6.20-rc3-mm1 2/2] libata: SiS 180 pata/sata support
Date: Mon, 08 Jan 2007 06:44:31 -0500 [thread overview]
Message-ID: <45A22E9F.1050607@garzik.org> (raw)
In-Reply-To: <20070108102809.512b4409@localhost.localdomain>
Alan wrote:
>> If the shared code is tiny, just create a header file and #include it
>> (sata_promise and sata_sx4 do this). Otherwise, create a shared library
>> module.
>
> pata_sis is both the SiS driver and the shared library. What needs fixing
It is /very/ bad policy to force the user to load a driver that drives
real hardware, just to be able to access a few functions. Hardware and
probe side effects are a very real possibility, and with this setup, the
user has /less/ control than normal over things such as load order when
pata_sis is loaded as a dependency.
If the duplicated code in question is small, just putting it in a header
file a la drivers/ata/sata_promise.h is fine. Otherwise, a library
approach with no side effects should be chosen.
Jeff
next prev parent reply other threads:[~2007-01-08 11:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-08 1:33 [PATCH 2.6.20-rc3-mm1 2/2] libata: SiS 180 pata/sata support Jeff Garzik
2007-01-08 10:28 ` Alan
2007-01-08 11:44 ` Jeff Garzik [this message]
2007-01-08 12:51 ` Alan
2007-01-08 12:50 ` Jeff Garzik
2007-01-08 15:30 ` Alan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45A22E9F.1050607@garzik.org \
--to=jeff@garzik.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-ide@vger.kernel.org \
--cc=sven@linux4geeks.de \
--cc=uwe.koziolek@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.