From: Andy Whitcroft <apw@shadowen.org>
To: Junio C Hamano <junkio@cox.net>
Cc: Juergen Ruehle <j.ruehle@bmiag.de>, git@vger.kernel.org
Subject: Re: [PATCH 2/4] Improve cached content header of status output
Date: Mon, 08 Jan 2007 13:28:41 +0000 [thread overview]
Message-ID: <45A24709.9090904@shadowen.org> (raw)
In-Reply-To: <7vk601fh7k.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano wrote:
> Juergen Ruehle <j.ruehle@bmiag.de> writes:
>
>> Andy Whitcroft writes:
>> > Junio C Hamano wrote:
>> > >
>> > > Somebody did not like the verb "stage"; perhaps we can say:
>> > >
>> > > # You have added changes to these files to be committed:
>> > > ...
>> >
>> > # These files have changes and are marked for commit:
>> >
>> > > # There are yet to be added changes to these files:
>> >
>> > # These files have changes but are not marked for commit:
>>
>> Does this better reflect that git tracks content and not files?
>>
>> # Changes to these files will be committed:
>>
>> # Changes to these files are not marked for commit:
>
> One of the goals is to find a pair of messages that make sense
> when the same file appears on both lists.
Doh, double changes ... yes.
I am not sure it is possible to sanely textualise that subtlety in a
single line. I wonder if its worth splitting this lot into three.
Basically those files on list one, those on list two and those on both.
Anyhow, lets see if we can textualise:
# Changes to these files will be committed:
# The latest changes to these files will not be committed:
The first here still implies its the latest changes. I can not
trivially word round that. Perhaps we could mention staging?
# Staged changes for these files will be commited:
# These files have unstaged changes which will not be committed:
>> BTW: how about also adding a hint how to review the changes in
>> question (i.e. diff --cached and diff; as an alternative to diff
>> --cached we could just advertise the --verbose switch to status and
>> commit).
>
> Sounds sane.
-apw
next prev parent reply other threads:[~2007-01-08 13:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-02 19:26 [PATCH/RFC] Assorted small changes to runstatus Juergen Ruehle
2007-01-02 19:26 ` [PATCH 1/4] Clarify syntax and role of git-add in status output Juergen Ruehle
2007-01-02 19:26 ` [PATCH 2/4] Improve cached content header of " Juergen Ruehle
2007-01-05 10:54 ` Andy Whitcroft
2007-01-05 11:22 ` Junio C Hamano
2007-01-05 13:14 ` Andy Whitcroft
2007-01-05 17:14 ` Juergen Ruehle
2007-01-05 18:42 ` Junio C Hamano
2007-01-08 13:28 ` Andy Whitcroft [this message]
2007-01-08 14:27 ` Juergen Ruehle
2007-01-02 19:26 ` [PATCH 3/4] Improve "nothing to commit" part " Juergen Ruehle
2007-01-02 19:26 ` [PATCH 4/4] Support --amend on initial commit in " Juergen Ruehle
2007-01-03 2:51 ` [PATCH/RFC] Assorted small changes to runstatus Junio C Hamano
2007-01-03 5:34 ` Juergen Ruehle
2007-01-07 19:18 ` [PATCH] Remove unnecessary git-rm --cached reference from status output Juergen Ruehle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45A24709.9090904@shadowen.org \
--to=apw@shadowen.org \
--cc=git@vger.kernel.org \
--cc=j.ruehle@bmiag.de \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.