From: Jeff Garzik <jgarzik@pobox.com>
To: Alan <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org, uwe.koziolek@gmx.net
Subject: Re: [PATCH] sata_sis: Support for PATA supports
Date: Mon, 08 Jan 2007 11:13:36 -0500 [thread overview]
Message-ID: <45A26DB0.8090106@pobox.com> (raw)
In-Reply-To: <20070108161107.121f196b@localhost.localdomain>
Alan wrote:
> This is quick rework of the patch Uwe proposed but using Kconfig not
> ifdefs and user selection to sort out PATA support. Instead of ifdefs and
> requiring the user to select both drivers the SATA driver selects the
> PATA one.
>
> For neatness I've also moved the extern into the function that uses it.
>
> Two questions really
> 1. Do you want the extern in a header file
not for an atom so small.
When I mentioned header files (if this was the genesis of your
question), I intentionally referred to sata_promise.h as an example of
sharing /code/ between two drivers.
> 2. Is this now neat enough to keep you happy Jeff or shall I do
> the library split anyway ?
It's still ugly relying on an unused driver like this, but this
[current] revision is clean enough that I'll go ahead and apply this patch.
Jeff
next prev parent reply other threads:[~2007-01-08 16:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-08 16:11 [PATCH] sata_sis: Support for PATA supports Alan
2007-01-08 16:13 ` Jeff Garzik [this message]
2007-01-09 10:37 ` Jeff Garzik
2007-01-25 1:28 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45A26DB0.8090106@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=uwe.koziolek@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.