From: Jun'ichi Nomura <j-nomura@ce.jp.nec.com>
To: lvm-devel@redhat.com
Subject: [LVM2 PATCH] (3/5) Allocate mirror log first
Date: Mon, 08 Jan 2007 12:11:46 -0500 [thread overview]
Message-ID: <45A27B52.80601@ce.jp.nec.com> (raw)
In-Reply-To: <45A2751E.5010707@ce.jp.nec.com>
This patch allows log allocation first to fix the problems that
lvconvert from linear to mirror and lvconvert from corelog to disklog
may allocate log from the same PV as mirror images.
What is the problem?
- Different (stronger) constraint should be applied to log area.
i.e. log must avoid all parallel areas, not only the ones
corresponding to the current LE.
In other words, _find_parallel_space() should use ah->parallel_areas
as whole for log allocation constraint. Whereas the part of it
(parallel_pvs) is used for the other allocation.
To fix it, this patch tries log allocation first and then others.
As a result of this change,
"--alloc anywhere" for mirror with log on the same device also starts
working. (It currently doesn't.)
Moving auto variables initialization after "restart" label
is not necessary but for avoiding future problem.
Thanks,
--
Jun'ichi Nomura, NEC Corporation of America
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 03-allocate-mirror-log-first.patch
Type: text/x-patch
Size: 5896 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/lvm-devel/attachments/20070108/d1bb0c43/attachment.bin>
next prev parent reply other threads:[~2007-01-08 17:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <45A2751E.5010707@ce.jp.nec.com>
2007-01-08 17:11 ` [LVM2 PATCH] (1/5) Separate mirror log allocation from _alloc_parallel_areas() Jun'ichi Nomura
2007-01-08 17:11 ` [LVM2 PATCH] (2/5) Fix mirror-log-only allocation failure Jun'ichi Nomura
2007-01-08 17:11 ` Jun'ichi Nomura [this message]
2007-01-08 17:11 ` [LVM2 PATCH] (4/5) Remove unnecessary prev_lvseg checks Jun'ichi Nomura
2007-01-08 17:12 ` [LVM2 PATCH] (5/5) Remove ix_offset Jun'ichi Nomura
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45A27B52.80601@ce.jp.nec.com \
--to=j-nomura@ce.jp.nec.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.