From: "Thomas Hellström" <thomas@tungstengraphics.com>
To: Arjan van de Ven <arjan@infradead.org>
Cc: davej@redhat.com, linux-kernel@vger.kernel.org,
Dave Airlie <airlied@gmail.com>
Subject: Re: agpgart: drm-populated memory types
Date: Tue, 09 Jan 2007 09:28:10 +0100 [thread overview]
Message-ID: <45A3521A.1080103@tungstengraphics.com> (raw)
In-Reply-To: <1168310231.3180.80.camel@laptopd505.fenrus.org>
Arjan van de Ven wrote:
>> A short recap why I belive the kmalloc / vmalloc construct is necessary:
>>
>> 0) The current code uses vmalloc only.
>> 1) The allocated area ranges from 4 bytes possibly up to 512 kB, depending on
>> on the size of the AGP buffer allocated.
>> 2) Large buffers are very few. Small buffers tend to be quite many.
>> If we continue to use vmalloc only or another page-based scheme we will
>> waste approx one page per buffer, together with the added slowness of
>> vmalloc. This will severely hurt applications with a lot of small
>> texture buffers.
>>
>> Please let me know if you still consider this unacceptable.
>>
>
> explicit use of either kmalloc/vmalloc is fine with me; I would suggest
> an 2*PAGE_SIZE cutoff for this decision
>
>
>>
>> In that case I suggest sticking with vmalloc for now.
>>
>> Also please let me know if there are other parths of the patch that should be
>> reworked.
>>
>> The patch that follows is against Dave's agpgart repo.
>>
>>
> <you forgot the patch>
>
>
Hmm.
Still struggling with git-send-email.
Now it should have arrived.
Thanks,
Thomas
next prev parent reply other threads:[~2007-01-09 8:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-08 18:24 [patch 1/2] agpgart - allow user-populated memory types Thomas Hellström
2006-12-08 22:03 ` Arjan van de Ven
2006-12-08 22:17 ` Arjan van de Ven
2006-12-08 23:05 ` Thomas Hellström
2006-12-19 8:47 ` Arjan van de Ven
2006-12-19 9:44 ` Thomas Hellström
2006-12-19 12:17 ` Arjan van de Ven
2006-12-19 12:47 ` Thomas Hellström
2006-12-19 13:11 ` Arjan van de Ven
2006-12-19 14:11 ` Thomas Hellström
2007-01-08 9:33 ` agpgart: drm-populated " thomas
2007-01-09 2:37 ` Arjan van de Ven
2007-01-09 8:28 ` Thomas Hellström [this message]
2007-01-09 8:23 ` [PATCH] agpgart: Allow drm-populated agp " thomas
2007-01-09 14:05 ` Arjan van de Ven
2007-01-09 14:06 ` Arjan van de Ven
2007-01-23 9:33 ` New patch: drm-populated " thomas
2007-01-23 9:33 ` [PATCH] agpgart: Allow drm-populated agp " thomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45A3521A.1080103@tungstengraphics.com \
--to=thomas@tungstengraphics.com \
--cc=airlied@gmail.com \
--cc=arjan@infradead.org \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.