Re: [PATCH] allow semodule -i to accept list of modules

[Karl MacMillan <kmacmillan@mentalrootkit.com>]

Joshua Brindle wrote:
> Karl MacMillan wrote:
>> Joshua Brindle wrote:
>>> Karl MacMillan wrote:
>>>> The following patch allows semodule to handle a list of modules for
>>>> installation (i.e., semodule -i *.pp now works).
>>>>
>>>>   
>>> Hrm, while the current syntax isn't ideal I don't think its the best 
>>> idea to change it abruptly. maybe you could make -I use the rest of 
>>> the arguments or something otherwise this will break any number of 
>>> rpm's, portage, the refpolicy makefiles and so on.
>>>
>>
>> I don't see how this could cause breakage as it doesn't change how any 
>> currently valid option sequence is processed. Instead, it makes 
>> invalid syntax valid (if you look closely at the patch, you can see 
>> that I am actually changing a fatal error path - so what I describe is 
>> guaranteed to be true).
>>
>> I prefer this approach because I think it is the least surprising. I 
>> constantly try the syntax this patch allows only to remember that it 
>> doesn't work.
>>
> 
> oops, you are right.. do you think having 2 distinct syntaxes for the 
> same argument will be less surprising than splitting them up?
> 

No. I think that common current usage is 'semodule -i somemodule.pp' and 
'semodule -i *.pp' (or some other glob) is very natural. I doubt that 
many people actually use 'semodule -i foo.pp -i bar.pp' besides some 
scripts.

Karl

--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.