From: Jeff Garzik <jeff@garzik.org>
To: Andy Gospodarek <andy@greyhouse.net>
Cc: fubar@us.ibm.com, netdev@vger.kernel.org
Subject: Re: [PATCH 1/1] bonding: eliminate RTNL assertion spew
Date: Tue, 09 Jan 2007 18:13:55 -0500 [thread overview]
Message-ID: <45A421B3.4020301@garzik.org> (raw)
In-Reply-To: <20070109225900.GA11755@gospo.rdu.redhat.com>
Andy Gospodarek wrote:
> -void bond_alb_handle_active_change(struct bonding *bond, struct slave *new_slave)
> +void bond_alb_handle_active_change(struct bonding *bond, struct slave *new_slave, int rtnl_locked)
> {
> struct slave *swap_slave;
> int i;
Although this is not a direct NAK (haven't read the full patch yet),
conditional locking behavior like this is /very/ fragile, and in Linux
is generally discouraged. Vendor drivers in particular have a history
of constantly getting this wrong, and it makes locking more difficult to
review.
Jeff
next prev parent reply other threads:[~2007-01-09 23:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-09 22:59 [PATCH 1/1] bonding: eliminate RTNL assertion spew Andy Gospodarek
2007-01-09 23:09 ` Stephen Hemminger
2007-01-10 19:33 ` Andy Gospodarek
2007-01-10 19:53 ` Stephen Hemminger
2007-08-15 3:14 ` Mike Snitzer
2007-08-15 3:27 ` Andy Gospodarek
2007-08-15 18:36 ` Mike Snitzer
2007-08-15 19:15 ` Jay Vosburgh
2007-01-09 23:13 ` Jeff Garzik [this message]
2007-01-09 23:34 ` Andy Gospodarek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45A421B3.4020301@garzik.org \
--to=jeff@garzik.org \
--cc=andy@greyhouse.net \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.