Re: xt_MARK useless line

[Patrick McHardy <kaber@trash.net>]

Jan Engelhardt wrote:
> On Jan 10 2007 06:53, Patrick McHardy wrote:
> 
>>I vote for removing this (also in CONNMARK, CONNSECMARK, ...).
>>
> 
> 
> Not everywhere, xt_CONNMARK has a place where:
> 
> newmark = (*ctmark & ~markinfo->mask) | markinfo->mark;
> if (newmark != *ctmark) {
>     *ctmark = newmark;
> #if defined(CONFIG_IP_NF_CONNTRACK) || defined(CONFIG_IP_NF_CONNTRACK_MODULE)
>     ip_conntrack_event_cache(IPCT_MARK, *pskb);
> #else
>     nf_conntrack_event_cache(IPCT_MARK, *pskb);
> #endif
> }
> 
> Would it matter to call these cache functions it even if the mark did
> not really change?

Yes.

> 
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Remove unnecessary if() constructs before assignment.
> Plus one spelling fix, one brace indent fix.

Queued for 2.6.21 (without the spelling fix since that touched
a totally unrelated file), thanks.