From: Jeff Garzik <jgarzik@pobox.com>
To: Alan <alan@lxorguk.ukuu.org.uk>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] libata: PIIX3 support
Date: Wed, 10 Jan 2007 12:27:25 -0500 [thread overview]
Message-ID: <45A521FD.7060303@pobox.com> (raw)
In-Reply-To: <20070110171338.5cd555b1@localhost.localdomain>
Alan wrote:
> @@ -786,7 +797,8 @@
> { 2, 3 }, };
>
> pci_read_config_word(dev, master_port, &master_data);
> - pci_read_config_byte(dev, 0x48, &udma_enable);
> + if (ap->udma_mask)
> + pci_read_config_byte(dev, 0x48, &udma_enable);
>
> if (speed >= XFER_UDMA_0) {
> unsigned int udma = adev->dma_mode - XFER_UDMA_0;
This creates a situation where the code modifies an uninitialized
variable. Ultimately irrelevant, but please init udma_enable to zero so
that at least it is valid C code.
Otherwise ACK.
Jeff
next prev parent reply other threads:[~2007-01-10 17:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-10 17:13 [PATCH] libata: PIIX3 support Alan
2007-01-10 17:27 ` Jeff Garzik [this message]
2007-01-20 0:14 ` Jeff Garzik
2007-01-22 4:17 ` ATA - pata_mpiix.c support for 82371AB chipsets? John Stoffel
2007-01-22 21:02 ` Alan
-- strict thread matches above, loose matches on Subject: below --
2007-01-12 1:08 [PATCH] libata: PIIX3 support Mikael Pettersson
2007-01-12 1:26 ` Alan
[not found] <fa.wgyMaLVtkeBqyNAZjGg9fEi3shs@ifi.uio.no>
2007-01-14 1:27 ` Robert Hancock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45A521FD.7060303@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.