From: "Jan Beulich" <jbeulich@novell.com>
To: xen-devel@lists.xensource.com, Keir Fraser <keir@xensource.com>
Cc: John Levon <levon@movementarian.org>
Subject: Re: [PATCH] fix build when CONFIG_COMPAT disabled
Date: Thu, 11 Jan 2007 16:31:28 +0000 [thread overview]
Message-ID: <45A67470.76E4.0078.0@novell.com> (raw)
In-Reply-To: <C1CC0C8D.77B4%keir@xensource.com>
>>> Keir Fraser <keir@xensource.com> 11.01.07 16:47 >>>
>On 11/1/07 15:42, "Jan Beulich" <jbeulich@novell.com> wrote:
>
>> Properly conditionalize two places where compat-only structure fields get
>> accessed, and avoid compiler warnings on unused variables in two other
>> places.
>
>Should we bother to #ifdef where we don't need to? It's ugly and the
>compiler should be able to remove dead code where a condition evaluates to
>zero at compile time: we already have IS_COMPAT(d) hardcoded to zero if
>!CONFIG_COMPAT, which is enough to give the compiler a fair chance.
Generally no, but in the one case in the patch we have to, as the structure
member (mm_arg_xlat_l3) doesn't exist without CONFIG_COMPAT.
Jan
next prev parent reply other threads:[~2007-01-11 16:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-11 15:42 [PATCH] fix build when CONFIG_COMPAT disabled Jan Beulich
2007-01-11 15:47 ` Keir Fraser
2007-01-11 16:17 ` John Levon
2007-01-11 16:31 ` Jan Beulich [this message]
2007-01-11 17:57 ` Keir Fraser
2007-01-12 0:10 ` John Levon
2007-01-12 7:49 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45A67470.76E4.0078.0@novell.com \
--to=jbeulich@novell.com \
--cc=keir@xensource.com \
--cc=levon@movementarian.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.