Re: [PATCH 00 of 10] Teach xm save to checkpoint a

[Yoshiaki Tamura <tamura.yoshiaki@lab.ntt.co.jp>]

Hi Brendan,

> sorry for the late reply - I went on vacation shortly after your
> post. 

No problem at all. I was on vacation too.

> I'm working on incorporating Keir's feedback at the moment,
> which seems to include your suggestion. I'll post a new patch series
> soon.

That's nice to hear. I'm looking forward to seeing the new patches.

> By the way, how were you doing checkpointed live migration? Didn't the
> old and new domains fight over the network and block devices?

Of course if you unpause the new domain, they will fight and destroy the shared 
storage. I just keep the new domain paused until the old domain has disappeared.
If the domain's workload is low, you can see the identical domains running 
concurrently for a moment just for fun. But you should be careful :-)

Thanks,

Yoshi

> 
>> Regards,
>>
>> Yoshi Tamura
>>
>>
>> Signed-off-by: Yoshi Tamura <tamura.yoshiaki@lab.ntt.co.jp>
>>
>> diff -r 3bde632518a4 linux-2.6-xen-sparse/drivers/xen/core/machine_reboot.c
>> 23:05:42 2006 -0800
>> +++ b/linux-2.6-xen-sparse/drivers/xen/core/machine_reboot.c	Wed Dec 20 
>> 16:21:43 2006 +0900
>> @@ -171,8 +171,6 @@ int __xen_suspend(void)
>>
>>  	pre_suspend();
>>
>> -	gnttab_checkpoint();
>> -
>>  	/*
>>  	 * We'll stop somewhere inside this hypercall. When it returns,
>>  	 * we'll start resuming after the restore.
>> @@ -223,6 +221,8 @@ int __xen_checkpoint(void)
>>
>>  	xenbus_lock();
>>
>> +	gnttab_suspend();
>> +
>>  	preempt_disable();
>>
>>  	mm_pin_all();
>> @@ -257,6 +257,8 @@ int __xen_checkpoint(void)
>>  	} else {
>>  		post_checkpoint();
>>
>> +		gnttab_resume();
>> +
>>  		local_irq_enable();
>>
>>  		xenbus_unlock();
>>
>>
>>
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
> 
> 
>