From: Eric Sandeen <sandeen@redhat.com>
To: Alex Tomas <alex@clusterfs.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] [RFC] remove ext3 inode from orphan list when link and unlink race
Date: Fri, 12 Jan 2007 15:48:03 -0600 [thread overview]
Message-ID: <45A80213.5060401@redhat.com> (raw)
In-Reply-To: <m3lkk8ym2f.fsf@bzzz.home.net>
Alex Tomas wrote:
>>>>>> Eric Sandeen (ES) writes:
>
> ES> so I think it's possible that link can sneak in there & find it after
> ES> the mutex is dropped...? Is this ok? :) It's certainly -happening-
> ES> anyway....
>
> yes, but it shouldn't allow to re-link such inode back, IMHO.
> a filesystem may start some non-revertable activity in its
> unlink method.
>
> thanks, Alex
I tend to agree, chatting w/ Al I think he does too. :) I'll test
a patch that kicks out ext3_link() with -ENOENT at the top, and resubmit
that if things go well.
-Eric
next prev parent reply other threads:[~2007-01-12 21:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-12 20:45 [PATCH] [RFC] remove ext3 inode from orphan list when link and unlink race Eric Sandeen
2007-01-12 21:02 ` Alex Tomas
2007-01-12 21:14 ` Eric Sandeen
2007-01-12 21:25 ` Alex Tomas
2007-01-12 21:48 ` Eric Sandeen [this message]
2007-01-12 21:55 ` Alex Tomas
2007-01-12 22:01 ` Eric Sandeen
2007-01-12 22:07 ` Alex Tomas
2007-01-12 22:35 ` Eric Sandeen
2007-01-12 21:17 ` Alex Tomas
2007-01-12 21:24 ` Dave Kleikamp
2007-01-14 11:58 ` Dmitriy Monakhov
2007-01-14 15:42 ` Eric Sandeen
2007-01-17 22:43 ` Andreas Dilger
2007-01-17 22:47 ` Eric Sandeen
2007-01-18 10:43 ` Andreas Dilger
2007-01-18 15:28 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45A80213.5060401@redhat.com \
--to=sandeen@redhat.com \
--cc=alex@clusterfs.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.