From mboxrd@z Thu Jan  1 00:00:00 1970
From: John Byrne <john.l.byrne@hp.com>
Subject: Re: Live migration leaves page tables read-only?
Date: Sat, 13 Jan 2007 20:11:15 -0800
Message-ID: <45A9AD63.6070308@hp.com>
References: <456CD0A5.1060701@hp.com> <456CD2DC.2020201@hp.com>
	<8A87A9A84C201449A0C56B728ACF491E01FA12@liverpoolst.ad.cl.cam.ac.uk>
	<456CF5F9.7070009@hp.com> <456F6AF5.2090005@hp.com>
	<8A87A9A84C201449A0C56B728ACF491E01FA69@liverpoolst.ad.cl.cam.ac.uk>
	<457A4C68.6050800@hp.com>
	<8A87A9A84C201449A0C56B728ACF491E04EE29@liverpoolst.ad.cl.cam.ac.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <8A87A9A84C201449A0C56B728ACF491E04EE29@liverpoolst.ad.cl.cam.ac.uk>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Ian Pratt <m+Ian.Pratt@cl.cam.ac.uk>
Cc: xen-devel <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org


Ian,

I haven't noticed a fix. Is someone working on this bug or should I open 
a bugzilla for it, so it isn't forgotten?

John Byrne

Ian Pratt wrote:
>  
>> I finally ran down the problem. SAP is protecting the pages PROT_NONE,
>> so the page-present bit in the pte is not set and
>> canonicalize/uncanonicalize code in save/restore ignore the pte. I've
>> attached a patch. It is possible that this change should be made to
> the
>> l1e tests in xc_ptrace.c; I'm not sure.
> 
> That's a good catch, thanks. Interesting that we hadn't seen this
> before.
> 
> Although your patch works today, it will break when we add PSE (super
> page) support for PV guests as it will confuse PROT_NONE with PSE.
> Assuming PROT_NONE only makes sense for L1 entries, we can probably gate
> the tests on whether the page table page is an L1 or not to fix this.
> 
> However, it does point out an issue for other OSes: Taking this patch
> effectively makes Linux's PROT_NONE (flags 0x80 for a not present PTE)
> part of the Xen API. We need to find out whether this is compatible with
> *BSD and Solaris' use of flags for not present ptes.
> 
> Ian
>