From: "Jan Beulich" <jbeulich@novell.com>
To: xen-devel@lists.xensource.com, Keir Fraser <keir@xensource.com>
Subject: Re: Linux: PG_pinned vs. PG_foreign
Date: Mon, 15 Jan 2007 11:36:09 +0000 [thread overview]
Message-ID: <45AB7539.76E4.0078.0@novell.com> (raw)
In-Reply-To: <C1D103B3.79E4%keir@xensource.com>
>>> Keir Fraser <keir@xensource.com> 15.01.07 11:10 >>>
>On 15/1/07 09:38, "Jan Beulich" <jbeulich@novell.com> wrote:
>
>> Is it intentional that these two both use PG_arch_1? It seems at least risky
>> to me... And if intended, it would certainly deserve a comment. (I was about
>> to utilize PG_pinned for indicating pinned highmem-allocated PTEs when I
>> realized this collision.)
>
>There's no reason to have them use the same bit if there's a PG_arch_2
>available. It was probbaly laziness on my part when I realised that (so far)
>ForeignPage and Pinned are mutually exclusive.
There isn't, but there are a few bits left, so that shouldn't be a problem.
PG_foreign really should be a standalone one, not using PR_arch_1, as
arches may have or get a meaning assigned for this (ia64 specifically has),
so even if it isn't a problem today it is very much like a latent bug.
I'll try to send a respective patch soon, but since I want to use this in our
code, too, I first have to resolve a collision with s390 patches from IBM,
which consume all the remaining bit positions.
Jan
prev parent reply other threads:[~2007-01-15 11:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-15 9:38 Linux: PG_pinned vs. PG_foreign Jan Beulich
2007-01-15 10:10 ` Keir Fraser
2007-01-15 11:36 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45AB7539.76E4.0078.0@novell.com \
--to=jbeulich@novell.com \
--cc=keir@xensource.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.