From: Kevin Jamieson <kjamieson@bycast.com>
To: xfs@oss.sgi.com
Subject: Re: Review: fix block reservation to work with per-cpu counters
Date: Mon, 15 Jan 2007 13:31:22 -0800 [thread overview]
Message-ID: <45ABF2AA.2010209@bycast.com> (raw)
This fails to build on non-SMP systems:
CC [M] fs/xfs/xfs_fsops.o
fs/xfs/xfs_fsops.c: In function 'xfs_fs_counts':
fs/xfs/xfs_fsops.c:463: warning: implicit declaration of function 'xfs_icsb_sync_counters_flags'
fs/xfs/xfs_fsops.c:463: error: 'XFS_ICSB_LAZY_COUNT' undeclared (first use in this function)
fs/xfs/xfs_fsops.c:463: error: (Each undeclared identifier is reported only once
fs/xfs/xfs_fsops.c:463: error: for each function it appears in.)
fs/xfs/xfs_fsops.c: In function 'xfs_reserve_blocks':
fs/xfs/xfs_fsops.c:525: error: 'XFS_ICSB_SB_LOCKED' undeclared (first use in this function)
make[1]: *** [fs/xfs/xfs_fsops.o] Error 1
make: *** [fs/xfs/xfs.ko] Error 2
The define for not HAVE_PERCPU_SB needs to be changed:
Index: fs/xfs/xfs_mount.h
===================================================================
RCS file: /cvs/linux-2.6-xfs/fs/xfs/xfs_mount.h,v
retrieving revision 1.232
diff -u -r1.232 xfs_mount.h
--- fs/xfs/xfs_mount.h 10 Jan 2007 14:42:52 -0000 1.232
+++ fs/xfs/xfs_mount.h 15 Jan 2007 21:13:09 -0000
@@ -311,7 +311,7 @@
#else
#define xfs_icsb_init_counters(mp) (0)
-#define xfs_icsb_sync_counters_lazy(mp) do { } while (0)
+#define xfs_icsb_sync_counters_flags(mp, flags) do { } while (0)
#endif
typedef struct xfs_mount {
next reply other threads:[~2007-01-15 22:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-15 21:31 Kevin Jamieson [this message]
2007-01-15 23:47 ` Review: fix block reservation to work with per-cpu counters David Chinner
2007-01-16 12:06 ` David Chatterton
-- strict thread matches above, loose matches on Subject: below --
2007-01-08 6:10 David Chinner
2007-01-08 10:52 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45ABF2AA.2010209@bycast.com \
--to=kjamieson@bycast.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.