From: Brian King <brking@linux.vnet.ibm.com>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: Jeff Garzik <jgarzik@pobox.com>, Alan <alan@lxorguk.ukuu.org.uk>,
linux-scsi@vger.kernel.org,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
Tejun Heo <htejun@gmail.com>
Subject: Re: ipr SATA problems in 2.6.20
Date: Tue, 16 Jan 2007 17:17:59 -0600 [thread overview]
Message-ID: <45AD5D27.8020004@linux.vnet.ibm.com> (raw)
In-Reply-To: <1168989094.2789.20.camel@mulgrave.il.steeleye.com>
James Bottomley wrote:
> On Tue, 2007-01-16 at 17:45 -0500, Jeff Garzik wrote:
>> Tejun recently updated the CDB length areas of the code. I bet it's
>> either a bug somewhere in there, or the SCSI layer isn't passing us
>> proper command lengths in a case or two.
>>
>> Additional traces (starting with SCSI command, before it hits libata)
>> would be helpful.
>
> Actually, this looks like a potential bug in atapi_xlat(): it doesn't
> set qc->dma_dir. Shouldn't it be setting it from
> qc->scsicmd->sc_data_direction like ata_scsi_translate() does?
I think we are OK here since atapi_xlate is only ever called by
ata_scsi_translate.
Brian
--
Brian King
eServer Storage I/O
IBM Linux Technology Center
next prev parent reply other threads:[~2007-01-16 23:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-16 22:24 ipr SATA problems in 2.6.20 Brian King
2007-01-16 22:41 ` Alan
2007-01-16 22:45 ` Jeff Garzik
2007-01-16 23:11 ` James Bottomley
2007-01-16 23:17 ` Brian King [this message]
2007-01-16 23:30 ` James Bottomley
2007-01-16 23:33 ` Brian King
2007-01-17 2:34 ` [PATCH] libata: initialize qc->dma_dir to DMA_NONE Tejun Heo
2007-01-17 3:43 ` Brian King
2007-01-17 3:59 ` Jeff Garzik
2007-01-17 14:37 ` Brian King
2007-01-17 18:35 ` Brian King
2007-01-17 15:19 ` James Bottomley
2007-01-17 15:49 ` Tejun Heo
2007-01-17 16:07 ` James Bottomley
2007-01-20 0:19 ` Jeff Garzik
2007-01-16 23:28 ` ipr SATA problems in 2.6.20 Alan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45AD5D27.8020004@linux.vnet.ibm.com \
--to=brking@linux.vnet.ibm.com \
--cc=James.Bottomley@SteelEye.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=htejun@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.