All of lore.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Mikael Pettersson <mikpe@it.uu.se>
Cc: giuliano.procida@googlemail.com, rgooch@atnf.csiro.au,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH]: MTRR: fix 32-bit ioctls on x64_32
Date: Tue, 16 Jan 2007 19:51:53 -0800	[thread overview]
Message-ID: <45AD9D59.6010006@zytor.com> (raw)
In-Reply-To: <200701161248.l0GCmG7O025771@harpo.it.uu.se>

Mikael Pettersson wrote:
> 
> These #ifdefs are too ugly.
> 
> Since you apparently just add aliases for the case labels,
> and do no actual code changes, why not
> 1. make the new cases unconditional, or 
> 2. invoke a translation function before the switch which
>    maps the MTRRCIOC32_ constants to what the kernel uses
> 

Adding a case can add substantially to the generated code, especially if 
it makes a compact set of case labels non-compact.

	-hpa

  parent reply	other threads:[~2007-01-17  3:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-16 12:48 [PATCH]: MTRR: fix 32-bit ioctls on x64_32 Mikael Pettersson
2007-01-16 17:59 ` Giuliano Procida
2007-01-17  3:51 ` H. Peter Anvin [this message]
2007-01-23 13:23   ` Giuliano Procida
  -- strict thread matches above, loose matches on Subject: below --
2007-01-16  8:14 Giuliano Procida

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45AD9D59.6010006@zytor.com \
    --to=hpa@zytor.com \
    --cc=giuliano.procida@googlemail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mikpe@it.uu.se \
    --cc=rgooch@atnf.csiro.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.