From: Josh Triplett <josh@freedesktop.org>
To: Christopher Li <sparse@chrisli.org>
Cc: linux-sparse@vger.kernel.org
Subject: Re: [PATCH 4] Update usage chain for dead instruction
Date: Tue, 16 Jan 2007 21:20:14 -0800 [thread overview]
Message-ID: <45ADB20E.60002@freedesktop.org> (raw)
In-Reply-To: <20070117023717.GD962@chrisli.org>
[-- Attachment #1: Type: text/plain, Size: 700 bytes --]
Christopher Li wrote:
> This patch address some of the dead instruction
> left in the usage chain.
Merged.
One minor style note:
> --- sparse.orig/simplify.c 2006-12-21 14:35:18.000000000 -0800
> +++ sparse/simplify.c 2006-12-21 14:35:55.000000000 -0800
> @@ -217,6 +217,11 @@ void kill_instruction(struct instruction
> kill_use(&insn->src2);
> kill_use(&insn->src3);
> return;
> + case OP_BR:
> + insn->bb = NULL;
> + repeat_phase |= REPEAT_CSE;
> + if (insn->cond)
> + kill_use(&insn->cond);
> }
> }
Despite redundancy, please include return or break statements in the last case
of a switch, to make modifications less error-prone.
- Josh Triplett
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 252 bytes --]
prev parent reply other threads:[~2007-01-17 5:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-17 2:37 [PATCH 4] Update usage chain for dead instruction Christopher Li
2007-01-17 5:20 ` Josh Triplett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45ADB20E.60002@freedesktop.org \
--to=josh@freedesktop.org \
--cc=linux-sparse@vger.kernel.org \
--cc=sparse@chrisli.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.