Re: [PATCH] qemu-dm monitor doesn't support the quit command

[Anthony Liguori <aliguori@linux.vnet.ibm.com>]

Kasai Takanori wrote:
> Hi All,
> 
> I made the patch that changed it from quit or q to quitdomain. I think 
> that the HVM domain can be prevented being shutted down by the mistake 
> in this patch. If there is any problem, please let me know.

It seems to me that this is just one more thing to get us further away
from the upstream QEMU tree and to me, that's a bad thing.  It's not
this one patch in particular but once you get enough of these, it starts
getting hairy.

If you really thing the q command is poorly named, I think you should
make that case to the QEMU community.  It really isn't a Xen specific issue.

If this really is a problem for you, couldn't you just keep the patch
around for your own use?  I haven't seen anyone else complain of this
issue before so I'm not sure it will do anything but confuse other people.

Regards,

Anthony Liguori

>>> quit command is useful when we have no host console(e.g. qemu window 
>>> on a remote
>>> X). and it's a normal exit that is different from xm destroy(by KILL 
>>> sig).
>>>
>>> maybe we can change "q" to "quit" to avoid typo? or provide confirm 
>>> info?
>>>
>>> BTW, "q" is most popular command when we debug qemu device model:)
>>
>> I understood the "quit" or "q" command was necessary for debugging.
>> However, there is a possibility that the user shuts down the HVM 
>> domain by mistake.
>>
>> Cannot you change "quit" or "q" to "quitdomain"?
> 
> Thanks,
> 
> -- 
> Takanori Kasai
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel