From: Brian Haley <brian.haley@hp.com>
To: Sridhar Samudrala <sri@us.ibm.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
lksctp-developers@lists.sourceforge.net
Subject: Re: [PATCH 2/4] [SCTP]: Verify some mandatory parameters.
Date: Wed, 17 Jan 2007 15:22:21 -0500 [thread overview]
Message-ID: <45AE857D.8000208@hp.com> (raw)
In-Reply-To: <1168544487.22592.19.camel@w-sridhar2.beaverton.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 389 bytes --]
> --- a/net/sctp/sm_statefuns.c
> +++ b/net/sctp/sm_statefuns.c
> @@ -462,24 +461,6 @@ sctp_disposition_t sctp_sf_do_5_1C_ack(const struct sctp_endpoint *ep,
> - if (!init_tag) {
> - struct sctp_chunk *reply = sctp_make_abort(asoc, chunk, 0);
> - if (!reply)
> - goto nomem;
This introduced a compiler warning, easily fixed.
-Brian
Signed-off-by: Brian Haley <brian.haley@hp.com>
[-- Attachment #2: sctp_warn.patch --]
[-- Type: text/x-patch, Size: 331 bytes --]
diff --git a/net/sctp/sm_statefuns.c b/net/sctp/sm_statefuns.c
index fce1f60..fbbc9e6 100644
--- a/net/sctp/sm_statefuns.c
+++ b/net/sctp/sm_statefuns.c
@@ -531,9 +531,6 @@ sctp_disposition_t sctp_sf_do_5_1C_ack(c
SCTP_CHUNK(err_chunk));
return SCTP_DISPOSITION_CONSUME;
-
-nomem:
- return SCTP_DISPOSITION_NOMEM;
}
/*
next prev parent reply other threads:[~2007-01-17 20:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-11 19:41 [PATCH 2/4] [SCTP]: Verify some mandatory parameters Sridhar Samudrala
2007-01-16 3:15 ` David Miller
2007-01-17 20:22 ` Brian Haley [this message]
2007-01-24 6:32 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45AE857D.8000208@hp.com \
--to=brian.haley@hp.com \
--cc=davem@davemloft.net \
--cc=lksctp-developers@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
--cc=sri@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.