From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gerd Hoffmann Subject: Re: 32-on-64: pvfb issue Date: Mon, 22 Jan 2007 16:33:11 +0100 Message-ID: <45B4D937.5070502@suse.de> References: <45B46CBF.7010406@suse.de> <45B4C3C0.1030406@suse.de> <87bqkrqe6q.fsf@pike.pond.sub.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <87bqkrqe6q.fsf@pike.pond.sub.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Markus Armbruster Cc: Xen devel list , Keir Fraser List-Id: xen-devel@lists.xenproject.org Markus Armbruster wrote: > Gerd Hoffmann writes: > >> + ret = xenbus_printf(xbt, dev->nodename, "protocol", "%s", >> + XEN_IO_PROTO_ABI_NATIVE); >> + if (ret) >> + goto error_xenbus; > > This identifies the ABI, but how does it provide versioning? #define XEN_IO_PROTO_FB_GRANT_TABLES "fb-grant-tables" ? Just create a descriptive name you like. Assuming we don't create abi-dependent structs *again* when we change the protocol. We can of course also just use XEN_IO_PROTO_ABI_NATIVE "-v2". With the protocol identifier being a string there lots of ways ... cheers, Gerd -- Gerd Hoffmann