From: Simon 'corecode' Schubert <corecode@fs.ei.tum.de>
To: Peter Eriksen <s022018@student.dtu.dk>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] sha1_file.c: Avoid multiple calls to find_pack_entry().
Date: Mon, 22 Jan 2007 21:56:01 +0100 [thread overview]
Message-ID: <45B524E1.5060205@fs.ei.tum.de> (raw)
In-Reply-To: <20070122202945.GA29297@bohr.gbar.dtu.dk>
[-- Attachment #1: Type: text/plain, Size: 817 bytes --]
Peter Eriksen wrote:
> We used to call find_pack_entry() twice from read_sha1_file() in order
> to avoid printing an error message, when the object did not exist. This
> is fixed by moving the call to error() to the only place it really
> could be called.
>
> Signed-off-by: Peter Eriksen <s022018@student.dtu.dk>
I noticed this originally, Peter was so kind to come up with a patch. Reviewed and found +1, so:
Signed-off-by: Simon 'corecode' Schubert <corecode@fs.ei.tum.de>
cheers
simon
--
Serve - BSD +++ RENT this banner advert +++ ASCII Ribbon /"\
Work - Mac +++ space for low €€€ NOW!1 +++ Campaign \ /
Party Enjoy Relax | http://dragonflybsd.org Against HTML \
Dude 2c 2 the max ! http://golden-apple.biz Mail + News / \
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 252 bytes --]
next prev parent reply other threads:[~2007-01-22 20:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-22 20:29 [PATCH] sha1_file.c: Avoid multiple calls to find_pack_entry() Peter Eriksen
2007-01-22 20:56 ` Simon 'corecode' Schubert [this message]
2007-01-22 21:07 ` Shawn O. Pearce
2007-01-23 0:25 ` Linus Torvalds
2007-01-23 0:39 ` Jakub Narebski
2007-01-23 2:10 ` Morten Welinder
2007-01-23 3:17 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45B524E1.5060205@fs.ei.tum.de \
--to=corecode@fs.ei.tum.de \
--cc=git@vger.kernel.org \
--cc=s022018@student.dtu.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.