From: Jeff Garzik <jeff@garzik.org>
To: Ananda Raju <Ananda.Raju@neterion.com>
Cc: netdev@vger.kernel.org, leonid.grossman@neterion.com,
alicia.pena@neterion.com, ramkrishna.vepa@neterion.com,
sivakumar.subramani@neterion.com, sreenivasa.honnur@neterion.com,
sriram.rapuru@neterion.com
Subject: Re: [PATCH 2.6.20 3/5] s2io: Fixes in updating skb->truesize and code cleanup.
Date: Tue, 23 Jan 2007 00:46:47 -0500 [thread overview]
Message-ID: <45B5A147.6050205@garzik.org> (raw)
In-Reply-To: <Pine.GSO.4.10.10701190234530.22012-100000@guinness>
Ananda Raju wrote:
> @@ -6999,7 +7003,7 @@ s2io_init_nic(struct pci_dev *pdev, cons
> goto mem_alloc_failed;
> }
>
> - sp->bar0 = ioremap(pci_resource_start(pdev, 0),
> + sp->bar0 = (caddr_t) ioremap(pci_resource_start(pdev, 0),
> pci_resource_len(pdev, 0));
> if (!sp->bar0) {
> DBG_PRINT(ERR_DBG, "%s: Neterion: cannot remap io mem1\n",
> @@ -7008,7 +7012,7 @@ s2io_init_nic(struct pci_dev *pdev, cons
> goto bar0_remap_failed;
> }
>
> - sp->bar1 = ioremap(pci_resource_start(pdev, 2),
> + sp->bar1 = (caddr_t) ioremap(pci_resource_start(pdev, 2),
> pci_resource_len(pdev, 2));
> if (!sp->bar1) {
> DBG_PRINT(ERR_DBG, "%s: Neterion: cannot remap io mem2\n",
adds pointless casts.
further, caddr_t type should /never/ be used.
Linux kernel uses void*, from which you may assign to/from freely,
without casting.
> @@ -7645,6 +7649,7 @@ static void lro_append_pkt(nic_t *sp, lr
> lro->last_frag->next = skb;
> else
> skb_shinfo(first)->frag_list = skb;
> + first->truesize += skb->truesize;//updating skb->truesize
> lro->last_frag = skb;
> sp->mac_control.stats_info->sw_stat.clubbed_frms_cnt++;
> return;
pointless comment (and C++ too, which is discouraged)
next prev parent reply other threads:[~2007-01-23 5:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-19 7:38 [PATCH 2.6.20 3/5] s2io: Fixes in updating skb->truesize and code cleanup Ananda Raju
2007-01-23 5:46 ` Jeff Garzik [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-01-23 19:57 Ananda Raju
2007-01-29 5:55 Ananda Raju
2007-01-31 18:32 Sivakumar Subramani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45B5A147.6050205@garzik.org \
--to=jeff@garzik.org \
--cc=Ananda.Raju@neterion.com \
--cc=alicia.pena@neterion.com \
--cc=leonid.grossman@neterion.com \
--cc=netdev@vger.kernel.org \
--cc=ramkrishna.vepa@neterion.com \
--cc=sivakumar.subramani@neterion.com \
--cc=sreenivasa.honnur@neterion.com \
--cc=sriram.rapuru@neterion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.