From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gerd Hoffmann <kraxel@suse.de>
Subject: Re: 32-on-64: pvfb issue
Date: Wed, 24 Jan 2007 13:38:27 +0100
Message-ID: <45B75343.1090409@suse.de>
References: <C1DA7F58.801A%keir@xensource.com>
	<45B60548.4060003@suse.de>	<45B741B7.1080306@suse.de>
	<87sle0obnw.fsf@pike.pond.sub.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <87sle0obnw.fsf@pike.pond.sub.org>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Markus Armbruster <armbru@redhat.com>
Cc: Xen devel list <xen-devel@lists.xensource.com>, Keir Fraser <keir@xensource.com>
List-Id: xen-devel@lists.xenproject.org

  Hi,

>> @@ -560,10 +560,10 @@ int xenfb_attach_dom(struct xenfb *xenfb
>>  	if (xenfb_wait_for_frontend_initialised(&xenfb->kbd) < 0)
>>  		goto error;
>>  
>> -	if (xenfb_bind(&xenfb->fb) < 0)
>> -		goto error;
>>  	if (xenfb_bind(&xenfb->kbd) < 0)
>>  		goto error;
>> +	if (xenfb_bind(&xenfb->fb) < 0)
>> +		goto error;
>>  
>>  	if (xenfb_xs_scanf1(xsh, xenfb->fb.otherend, "feature-update",
>>  			    "%d", &val) < 0)
> 
> Why is this patch hunk necessary?

Oh, forgot to mention that, sorry.  Only vfb has a "protocol" node, vkbd
hasn't.  So binding fb last makes sure we have the protocol filled
correctly in the struct.

cheers,
  Gerd

-- 
Gerd Hoffmann <kraxel@suse.de>