From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: netfront pv driver building Date: Wed, 24 Jan 2007 13:46:17 +0000 Message-ID: <45B77139.76E4.0078.0@novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org netfront requires the symbol __supported_pte_mask when PAE is enabled in the kernel being built for. That symbol, however, isn't being exported, and it doesn't seem likely that mainline would want to see this get exported (after all, the general assumption is that the page table handling inline functions and macros are supposed to be used only by the memory management code). Additionally, both uses are inside a conditional depending upon !XENFEAT_auto_translated_physmap, which hence can't ever be true if this code is being built as pv driver. Wouldn't it hence make sense to #ifdef these code blocks, or to enhance xen/features.h so that checks for those features that are always on in hvm and return a constant 1 rather than using the xen_features array. Thanks, Jan