Re: [Qemu-devel] New multiple snapshot support for VMDK.

[Fabrice Bellard <fabrice@bellard.org>]

Hi,

Your patch seems OK to me.

Fabrice.

Igor Lvovsky wrote:
> 
> 
>    Hi Fabrice,
> 
> What are you think about this patch?
> 
> Are you have a comments?
> 
> If you accept it, I'll try to fix the race condition on snapshot writing.
> 
>                        
> 
>                         Regards
> 
>                                     Igor Lvovsky
> 
>  
> 
>            
> 
>  
> 
>  
> 
>  
> 
>  
> 
> * From: * qemu-devel-bounces+igor.lvovsky=qumranet.com@nongnu.org 
> [mailto:qemu-devel-bounces+igor.lvovsky=qumranet.com@nongnu.org] *On 
> Behalf Of * Igor Lvovsky
> *Sent:* Monday, January 15, 2007 4:51 PM
> *To:* qemu-devel@nongnu.org
> *Subject:* [Qemu-devel] New multiple snapshot support for VMDK.
> 
>  
> 
>    Hi all,
> 
> It's the new patch for the multiple snapshot support for the VMDK format.
> 
> I rewrote the previous one according to the new multiple snapshots 
> concept, introduced by Fabrice.
> 
>  
> 
> The snapshots can be created with standard way:
> 
>  
> 
> qemu-img create –b base-image.vmdk –f vmdk snapshot-img-001.vmdk
> 
>  
> 
> We can create the snapshots chain in this way.
> 
> The patch include also the 'CID' protection that defined by the VMDK 
> format.
> 
> The CID is a value updated on the first write every time the virtual 
> disk is opened.
> 
>  
> 
>  P.S. Fabrice, I used the bdrv_pread() and bdrv_pwrite(), as you advised 
> me.
> 
>  
> 
>             Regards,
> 
>                         Igor Lvovsky
> 
>  
> 
>  
> 
>  
> 
>  
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Qemu-devel mailing list
> Qemu-devel@nongnu.org
> http://lists.nongnu.org/mailman/listinfo/qemu-devel