From: Alexey Starikovskiy <alexey.y.starikovskiy@linux.intel.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Andrew Morton <akpm@osdl.org>,
linux-pm@osdl.org, "Brown, Len" <len.brown@intel.com>
Subject: Re: [PATCH] Fix swsusp-change-code-order-in-diskc.patch
Date: Thu, 25 Jan 2007 15:51:08 +0300 [thread overview]
Message-ID: <45B8A7BC.8060100@linux.intel.com> (raw)
In-Reply-To: <20070125124325.GH23343@elf.ucw.cz>
Pavel Machek wrote:
> Hi!
>
>
>> Recent patch from Rafael changed the order of platform_prepare() and
>> swsusp_read(). platform_prepare() should happen before swsusp_read()
>> in order to get nice LED blinking during load of the image and time for
>> GPE activity to settle down.
>>
>
> Well, looks acceptable to me.
>
> But if GPEs need some time to settle down, that should be done
> explicitely, and with _big_ comment? What if your disk is too fast?
>
> Also, same problem is likely present in uswsusp (and harder to fix
> there). Is this really required?
> Pavel
>
ACPI interrupt gets disabled if the GPE activity is not disabled before
switching to loaded image
on some Acer machines. In most cases disabling them just before
sw_switch() is enough, but it's better to
be on a safe side. And don't forget about blinking LED :)
Regards,
Alex.
prev parent reply other threads:[~2007-01-25 12:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-25 12:36 [PATCH] Fix swsusp-change-code-order-in-diskc.patch Alexey Starikovskiy
2007-01-25 12:43 ` Pavel Machek
2007-01-25 12:51 ` Alexey Starikovskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45B8A7BC.8060100@linux.intel.com \
--to=alexey.y.starikovskiy@linux.intel.com \
--cc=akpm@osdl.org \
--cc=len.brown@intel.com \
--cc=linux-pm@osdl.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.