From: Pierre Ossman <drzeus-list@drzeus.cx>
To: Carlos Aguiar <carlos.aguiar@indt.org.br>
Cc: "linux- >> omap-linux" <linux-omap-open-source@linux.omap.com>
Subject: Re: [PATCH] MMC: OMAP R6 response support
Date: Thu, 25 Jan 2007 16:19:29 +0100 [thread overview]
Message-ID: <45B8CA81.5080802@drzeus.cx> (raw)
In-Reply-To: <45B8B6D9.90006@indt.org.br>
Carlos Aguiar wrote:
> Hi folks,
>
> Regarding the commit below
>
> http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=6f949909e8f9e5d7e5584dc48d9a5e060c52aed1
> ,
>
> the definition of response type R6 is the same as R1 and case
>
That is intentional. All specs I have state that they have the same format.
> MMC_RSP_R6 was removed on omap.c, causing a error when inserting a SD
> card on OMAP platforms.
>
Do you have a dump I could see?
> This error occur due following the MMC and SD specs, on CMD3, response
> type is R6 to SD cards and R1 to MMC cards.
>
> So, I'm proposing a patch that try to solve this problem. I've tested
> it with SD and MMC cards and looks fine.
>
>
NAK. Opcodes should never be present in host drivers. It completely
kills forward compatibility. This should be fixed by figuring out what
the OMAP hardware does differently and do a general solution from that.
Rgds
--
-- Pierre Ossman
Linux kernel, MMC maintainer http://www.kernel.org
PulseAudio, core developer http://pulseaudio.org
rdesktop, core developer http://www.rdesktop.org
prev parent reply other threads:[~2007-01-25 15:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-25 13:55 [PATCH] MMC: OMAP R6 response support Carlos Aguiar
2007-01-25 15:19 ` Pierre Ossman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45B8CA81.5080802@drzeus.cx \
--to=drzeus-list@drzeus.cx \
--cc=carlos.aguiar@indt.org.br \
--cc=linux-omap-open-source@linux.omap.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.