From: Jeff Garzik <jgarzik@pobox.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: linuxppc-dev@ozlabs.org, alan@lxorguk.ukuu.org.uk
Subject: Re: [PATCH] Fix Maple PATA IRQ assignment.
Date: Fri, 26 Jan 2007 17:28:49 -0500 [thread overview]
Message-ID: <45BA80A1.8040900@pobox.com> (raw)
In-Reply-To: <1167679875.22068.350.camel@pmac.infradead.org>
David Woodhouse wrote:
> On the Maple board, the AMD8111 IDE is in legacy mode... except that it
> appears on IRQ 20 instead of IRQ 15. For drivers/ide this was handled by
> the architecture's "pci_get_legacy_ide_irq()" function, but in libata we
> just hard-code the numbers 14 and 15.
>
> This patch provides asm-powerpc/libata-portmap.h which maps the IRQ as
> appropriate, having added a pci_dev argument to the
> ATA_{PRIM,SECOND}ARY_IRQ macros.
>
> There's probably a better way to do this -- especially if we observe
> that the _only_ case in which this seemingly-generic
> "pci_get_legacy_ide_irq()" function returns anything other than 14 and
> 15 for primary and secondary respectively is the case of the AMD8111 on
> the Maple board -- couldn't we handle that with a special case in the
> pata_amd driver, or perhaps with a PCI quirk for Maple to switch it into
> native mode during early boot and assign resources properly?
>
> Signed-off-by: David Woodhouse <dwmw2@infradead.org>
applied
prev parent reply other threads:[~2007-01-26 22:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-01 19:31 [PATCH] Fix Maple PATA IRQ assignment David Woodhouse
2007-01-01 20:10 ` Benjamin Herrenschmidt
2007-01-01 20:26 ` David Woodhouse
2007-01-01 21:23 ` Benjamin Herrenschmidt
2007-01-01 20:44 ` Segher Boessenkool
2007-01-01 21:33 ` Benjamin Herrenschmidt
2007-01-01 22:17 ` Segher Boessenkool
2007-01-01 20:42 ` Segher Boessenkool
2007-01-01 20:56 ` David Woodhouse
2007-01-01 21:22 ` Alan
2007-01-01 21:15 ` David Woodhouse
2007-01-01 21:34 ` Alan
2007-01-01 21:43 ` David Woodhouse
2007-01-02 0:17 ` Benjamin Herrenschmidt
2007-01-02 0:18 ` Benjamin Herrenschmidt
2007-01-26 22:28 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45BA80A1.8040900@pobox.com \
--to=jgarzik@pobox.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=dwmw2@infradead.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.