From: Johannes Engel <j-engel@gmx.de>
To: corentincj@iksaif.net
Cc: Len Brown <lenb@kernel.org>,
linux-acpi@vger.kernel.org, acpi4asus-user@lists.sourceforge.net
Subject: Re: [Acpi4asus-user] [patch 7/7] asus-laptop: add light sensor support
Date: Fri, 26 Jan 2007 23:53:18 +0100 [thread overview]
Message-ID: <45BA865E.4040706@gmx.de> (raw)
In-Reply-To: <200701261404.58597.corentincj@iksaif.net>
Hi, Corentin!
Some remarks on your patch which upto now works great for me!
1.) configuration seems to have a "circle": Warning! Found recursive
dependency: ACPI_ASUS ASUS_LAPTOP ACPI_ASUS
2.) The dependency X86 makes it necessary to enable generic
X86-optimizations. Is that intended?
3.) With recent BIOS versions the implementation of the value for the
Touchpad LED has switched. So an "echo 0 > .../led" results in the led
to light. Maybe there is a way to deal with that in kernel space. But I
think we already had that discussion some months ago.
Greetings, Johannes
next prev parent reply other threads:[~2007-01-26 22:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-25 11:54 [patch 7/7] asus-laptop: add light sensor support Corentin CHARY
2007-01-26 13:04 ` Corentin CHARY
2007-01-26 22:53 ` Johannes Engel [this message]
2007-01-27 8:46 ` [Acpi4asus-user] " Corentin CHARY
2007-01-30 6:42 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45BA865E.4040706@gmx.de \
--to=j-engel@gmx.de \
--cc=acpi4asus-user@lists.sourceforge.net \
--cc=corentincj@iksaif.net \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.