From: Josh Triplett <josh@freedesktop.org>
To: Christopher Li <sparse@chrisli.org>
Cc: linux-sparse@vger.kernel.org
Subject: Re: [PATCH 8] Enhance debug information.
Date: Sat, 27 Jan 2007 00:48:42 -0800 [thread overview]
Message-ID: <45BB11EA.4060409@freedesktop.org> (raw)
In-Reply-To: <20070117024239.GI962@chrisli.org>
[-- Attachment #1: Type: text/plain, Size: 995 bytes --]
Christopher Li wrote:
> I found it very useful for debug_symbol to show the builtin
> type name.
Applied, with one minor style fix noted below.
> Signed-off-by: Christopher Li<sparse@chrisli.org>
>
> Index: sparse/symbol.h
> ===================================================================
> --- sparse.orig/symbol.h 2006-12-14 20:26:32.000000000 -0800
> +++ sparse/symbol.h 2006-12-14 20:28:01.000000000 -0800
> @@ -239,6 +239,8 @@ extern void bind_symbol(struct symbol *,
> extern struct symbol *examine_symbol_type(struct symbol *);
> extern void examine_simple_symbol_type(struct symbol *);
> extern const char *show_typename(struct symbol *sym);
> +extern const char* builtin_typename(struct symbol *sym);
> +extern const char* builtin_ctypename(struct ctype *ctype);
The * goes next to the name, not the type:
...char *builtin_..., not ...char* builtin_...
(The same issue applied to the definition of these two functions as well.)
- Josh Triplett
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 252 bytes --]
prev parent reply other threads:[~2007-01-27 8:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-17 2:42 [PATCH 8] Enhance debug information Christopher Li
2007-01-27 8:48 ` Josh Triplett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45BB11EA.4060409@freedesktop.org \
--to=josh@freedesktop.org \
--cc=linux-sparse@vger.kernel.org \
--cc=sparse@chrisli.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.