From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752230AbXA0JF7 (ORCPT ); Sat, 27 Jan 2007 04:05:59 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752232AbXA0JF7 (ORCPT ); Sat, 27 Jan 2007 04:05:59 -0500 Received: from mis011-2.exch011.intermedia.net ([64.78.21.129]:44804 "EHLO mis011-2.exch011.intermedia.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752231AbXA0JF6 (ORCPT ); Sat, 27 Jan 2007 04:05:58 -0500 Message-ID: <45BB15F1.6020600@qumranet.com> Date: Sat, 27 Jan 2007 11:05:53 +0200 From: Avi Kivity User-Agent: Thunderbird 1.5.0.9 (X11/20061219) MIME-Version: 1.0 To: caglar@pardus.org.tr CC: lkml , kvm-devel@lists.sourceforge.net Subject: Re: [PATCH] KVM: 'asm' operand has impossible constraints References: <200701260140.47760.caglar@pardus.org.tr> In-Reply-To: <200701260140.47760.caglar@pardus.org.tr> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-OriginalArrivalTime: 27 Jan 2007 09:05:57.0296 (UTC) FILETIME=[5B4C3300:01C741F2] Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org S.Çağlar Onur wrote: > Hi; > > -rc6 fails with latest gcc 4.2 snapshot as following; > > CC [M] drivers/kvm/svm.o > drivers/kvm/svm.c:206: warning: 'inject_db' defined but not used > drivers/kvm/svm.c: In function 'svm_vcpu_run': > drivers/kvm/kvm.h:560: error: 'asm' operand has impossible constraints > make[2]: *** [drivers/kvm/svm.o] Error 1 > make[1]: *** [drivers/kvm] Error 2 > make: *** [drivers] Error 2 > > And according to this thread http://lkml.org/lkml/2006/11/11/129, solution is > converting g to rm, patch follows > > The patch looks correct, but I don't understand the gcc error message. Are we sure this isn't a gcc 4.2 bug? "g" appears to be equivalent to "rmi", if "i" is impossible, gcc is free to use "r" or "m", no? > Signed-off-by: S.Çağlar Onur > > Index: linux-2.6/drivers/kvm/kvm.h > =================================================================== > --- linux-2.6.orig/drivers/kvm/kvm.h 2007-01-26 01:38:35.000000000 +0200 > +++ linux-2.6/drivers/kvm/kvm.h 2007-01-26 01:37:48.000000000 +0200 > @@ -557,7 +557,7 @@ > #ifndef load_ldt > static inline void load_ldt(u16 sel) > { > - asm ("lldt %0" : : "g"(sel)); > + asm ("lldt %0" : : "rm"(sel)); > } > #endif > > > -- Do not meddle in the internals of kernels, for they are subtle and quick to panic. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: 'asm' operand has impossible constraints Date: Sat, 27 Jan 2007 11:05:53 +0200 Message-ID: <45BB15F1.6020600@qumranet.com> References: <200701260140.47760.caglar@pardus.org.tr> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, lkml To: caglar-caicS1wCkhO6A22drWdTBw@public.gmane.org Return-path: In-Reply-To: <200701260140.47760.caglar-caicS1wCkhO6A22drWdTBw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Uy7Dh2HEn2xhciBPbnVyIHdyb3RlOgo+IEhpOwo+Cj4gLXJjNiBmYWlscyB3aXRoIGxhdGVzdCBn Y2MgNC4yIHNuYXBzaG90IGFzIGZvbGxvd2luZzsKPgo+IENDIFtNXSAgZHJpdmVycy9rdm0vc3Zt Lm8KPiBkcml2ZXJzL2t2bS9zdm0uYzoyMDY6IHdhcm5pbmc6ICdpbmplY3RfZGInIGRlZmluZWQg YnV0IG5vdCB1c2VkCj4gZHJpdmVycy9rdm0vc3ZtLmM6IEluIGZ1bmN0aW9uICdzdm1fdmNwdV9y dW4nOgo+IGRyaXZlcnMva3ZtL2t2bS5oOjU2MDogZXJyb3I6ICdhc20nIG9wZXJhbmQgaGFzIGlt cG9zc2libGUgY29uc3RyYWludHMKPiBtYWtlWzJdOiAqKiogW2RyaXZlcnMva3ZtL3N2bS5vXSBF cnJvciAxCj4gbWFrZVsxXTogKioqIFtkcml2ZXJzL2t2bV0gRXJyb3IgMgo+IG1ha2U6ICoqKiBb ZHJpdmVyc10gRXJyb3IgMgo+Cj4gQW5kIGFjY29yZGluZyB0byB0aGlzIHRocmVhZCBodHRwOi8v bGttbC5vcmcvbGttbC8yMDA2LzExLzExLzEyOSwgc29sdXRpb24gaXMgCj4gY29udmVydGluZyBn IHRvIHJtLCBwYXRjaCBmb2xsb3dzCj4KPiAgIAoKVGhlIHBhdGNoIGxvb2tzIGNvcnJlY3QsIGJ1 dCBJIGRvbid0IHVuZGVyc3RhbmQgdGhlIGdjYyBlcnJvciBtZXNzYWdlLiAgCkFyZSB3ZSBzdXJl IHRoaXMgaXNuJ3QgYSBnY2MgNC4yIGJ1Zz8KCiJnIiBhcHBlYXJzIHRvIGJlIGVxdWl2YWxlbnQg dG8gInJtaSIsIGlmICJpIiBpcyBpbXBvc3NpYmxlLCBnY2MgaXMgZnJlZSAKdG8gdXNlICJyIiBv ciAibSIsIG5vPwoKCj4gU2lnbmVkLW9mZi1ieTogUy7Dh2HEn2xhciBPbnVyIDxjYWdsYXJAcGFy ZHVzLm9yZy50cj4KPgo+IEluZGV4OiBsaW51eC0yLjYvZHJpdmVycy9rdm0va3ZtLmgKPiA9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Cj4gLS0tIGxpbnV4LTIuNi5vcmlnL2RyaXZlcnMva3ZtL2t2bS5oCTIwMDctMDEtMjYg MDE6Mzg6MzUuMDAwMDAwMDAwICswMjAwCj4gKysrIGxpbnV4LTIuNi9kcml2ZXJzL2t2bS9rdm0u aAkyMDA3LTAxLTI2IDAxOjM3OjQ4LjAwMDAwMDAwMCArMDIwMAo+IEBAIC01NTcsNyArNTU3LDcg QEAKPiAgI2lmbmRlZiBsb2FkX2xkdAo+ICBzdGF0aWMgaW5saW5lIHZvaWQgbG9hZF9sZHQodTE2 IHNlbCkKPiAgewo+IC0JYXNtICgibGxkdCAlMCIgOiA6ICJnIihzZWwpKTsKPiArCWFzbSAoImxs ZHQgJTAiIDogOiAicm0iKHNlbCkpOwo+ICB9Cj4gICNlbmRpZgo+Cj4KPiAgIAoKCi0tIApEbyBu b3QgbWVkZGxlIGluIHRoZSBpbnRlcm5hbHMgb2Yga2VybmVscywgZm9yIHRoZXkgYXJlIHN1YnRs ZSBhbmQgcXVpY2sgdG8gcGFuaWMuCgoKLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQpUYWtlIFN1cnZleXMuIEVh cm4gQ2FzaC4gSW5mbHVlbmNlIHRoZSBGdXR1cmUgb2YgSVQKSm9pbiBTb3VyY2VGb3JnZS5uZXQn cyBUZWNoc2F5IHBhbmVsIGFuZCB5b3UnbGwgZ2V0IHRoZSBjaGFuY2UgdG8gc2hhcmUgeW91cgpv cGluaW9ucyBvbiBJVCAmIGJ1c2luZXNzIHRvcGljcyB0aHJvdWdoIGJyaWVmIHN1cnZleXMgLSBh bmQgZWFybiBjYXNoCmh0dHA6Ly93d3cudGVjaHNheS5jb20vZGVmYXVsdC5waHA/cGFnZT1qb2lu LnBocCZwPXNvdXJjZWZvcmdlJkNJRD1ERVZERVYKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18Ka3ZtLWRldmVsIG1haWxpbmcgbGlzdAprdm0tZGV2ZWxAbGlz dHMuc291cmNlZm9yZ2UubmV0Cmh0dHBzOi8vbGlzdHMuc291cmNlZm9yZ2UubmV0L2xpc3RzL2xp c3RpbmZvL2t2bS1kZXZlbAo=