From: Jes Sorensen <jes@sgi.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH] Fix NULL-pointer dereference in ia64_machine_kexec()
Date: Sat, 27 Jan 2007 22:49:25 +0000 [thread overview]
Message-ID: <45BBD6F5.6040801@sgi.com> (raw)
In-Reply-To: <eparjg$nhq$1@sea.gmane.org>
Bernhard Walle wrote:
> Hello Jes,
>
> * Jes Sorensen <jes@sgi.com> [2007-01-27 07:28]:
>>>>>>> "Bernhard" = Bernhard Walle <bwalle@suse.de> writes:
>> Bernhard> printk(KERN_NOTICE "Kdump not configured\n");
>>
>> Wouldn't it make more sense to make that messages a bit more
>> descriptive? Ie. include something about what it tried to do when it
>> noticed it wasn't configured?
>
> Do you think
>
> machine_kdump_on_init(): kdump not configured
>
> would be better? That would make it easier to find the position of the
> message in code. Or did you think of a more verbal description like
That would do just fine I think, anything to avoid having to run find
and grep on the tree to figure out where it came from :)
Cheers,
Jes
next prev parent reply other threads:[~2007-01-27 22:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-25 18:06 [PATCH] Fix NULL-pointer dereference in ia64_machine_kexec() Bernhard Walle
2007-01-27 6:28 ` Jes Sorensen
2007-01-27 13:15 ` Bernhard Walle
2007-01-27 22:49 ` Jes Sorensen [this message]
2007-02-06 11:40 ` Bernhard Walle
2007-02-06 11:40 ` Bernhard Walle
2007-01-28 12:47 ` Bernhard Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45BBD6F5.6040801@sgi.com \
--to=jes@sgi.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.